From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 22CACC3FA for ; Fri, 19 Feb 2016 08:30:49 +0100 (CET) Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O2S0055GA7COY80@mailout1.w1.samsung.com> for dev@dpdk.org; Fri, 19 Feb 2016 07:30:48 +0000 (GMT) X-AuditID: cbfec7f4-f79026d00000418a-52-56c6c4a79d0b Received: from eusync1.samsung.com ( [203.254.199.211]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id 53.48.16778.7A4C6C65; Fri, 19 Feb 2016 07:30:47 +0000 (GMT) Received: from [106.109.129.180] by eusync1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0O2S00GQ7A7BU160@eusync1.samsung.com>; Fri, 19 Feb 2016 07:30:47 +0000 (GMT) To: Yuanhan Liu References: <1455863563-15751-1-git-send-email-i.maximets@samsung.com> <1455863563-15751-3-git-send-email-i.maximets@samsung.com> <20160219070650.GS21426@yliu-dev.sh.intel.com> From: Ilya Maximets Message-id: <56C6C4A6.2080507@samsung.com> Date: Fri, 19 Feb 2016 10:30:46 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: <20160219070650.GS21426@yliu-dev.sh.intel.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrJLMWRmVeSWpSXmKPExsVy+t/xy7rLjxwLM3j83tTi3aftTBbtM88y WUycZGIx/WmExeTZUhbXJ1xgdWDz2HCin9Xj14KlrB6L97xk8rhzbQ+bx7yTgR59W1YxBrBF cdmkpOZklqUW6dslcGUsvtrIWrCAu6Lh3HOWBsZVnF2MnBwSAiYSXa/72CFsMYkL99azdTFy cQgJLGWUmLVrMQuE84JR4vb752BVwgKeEt9bF4LZIgK6Ek/nrGOFKNrCKPHh+AN2EIdZYCOj xNmzz5lBqtgEdCROrT7CCGLzCmhJ7Dv5AsxmEVCVuLrrM9gkUYEIicOdXewQNYISPybfYwGx OQWsJdY8+wN0EwfQUD2J+xe1QMLMAvISm9e8ZZ7AKDALSccshKpZSKoWMDKvYhRNLU0uKE5K zzXUK07MLS7NS9dLzs/dxAgJ8C87GBcfszrEKMDBqMTDe8HgWJgQa2JZcWXuIUYJDmYlEV5d f6AQb0piZVVqUX58UWlOavEhRmkOFiVx3rm73ocICaQnlqRmp6YWpBbBZJk4OKUaGM1DRdMP n2X6t6Hqp/jhs177JvGUHFiW0rHNyGui6+tH0tsdNm/lPem+Su38DYspX4K22+089aJ1EvOP Rcmy/MntSYkXow5cXTPnlWn91uAO7T0TTzm7RwdPWGOw5f17TqNFORe89n988ul52nQN38NH bm1dun2H06vJ918vZFmquS2qpEH+YaaeEktxRqKhFnNRcSIA8PdOx2wCAAA= Cc: dev@dpdk.org, Dyasly Sergey Subject: Re: [dpdk-dev] [PATCH RFC 2/4] vhost: make buf vector for scatter RX local. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2016 07:30:49 -0000 On 19.02.2016 10:06, Yuanhan Liu wrote: > On Fri, Feb 19, 2016 at 09:32:41AM +0300, Ilya Maximets wrote: >> Array of buf_vector's is just an array for temporary storing information >> about available descriptors. It used only locally in virtio_dev_merge_rx() >> and there is no reason for that array to be shared. >> >> Fix that by allocating local buf_vec inside virtio_dev_merge_rx(). >> >> Signed-off-by: Ilya Maximets >> --- >> lib/librte_vhost/rte_virtio_net.h | 1 - >> lib/librte_vhost/vhost_rxtx.c | 45 ++++++++++++++++++++------------------- >> 2 files changed, 23 insertions(+), 23 deletions(-) >> >> diff --git a/lib/librte_vhost/rte_virtio_net.h b/lib/librte_vhost/rte_virtio_net.h >> index 10dcb90..ae1e4fb 100644 >> --- a/lib/librte_vhost/rte_virtio_net.h >> +++ b/lib/librte_vhost/rte_virtio_net.h >> @@ -91,7 +91,6 @@ struct vhost_virtqueue { >> int kickfd; /**< Currently unused as polling mode is enabled. */ >> int enabled; >> uint64_t reserved[16]; /**< Reserve some spaces for future extension. */ >> - struct buf_vector buf_vec[BUF_VECTOR_MAX]; /**< for scatter RX. */ >> } __rte_cache_aligned; > > I like this kind of cleanup, however, it breaks ABI. Should I prepare version of this patch with field above marked as deprecated and add note to doc/guides/rel_notes/release_16_04.rst about future deletion? Best regards, Ilya Maximets.