From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id ED1C6C49C for ; Fri, 19 Feb 2016 10:15:17 +0100 (CET) Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout1.w1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0O2S005G9EKRGJA0@mailout1.w1.samsung.com> for dev@dpdk.org; Fri, 19 Feb 2016 09:05:15 +0000 (GMT) X-AuditID: cbfec7f4-f79026d00000418a-09-56c6dacb32d0 Received: from eusync3.samsung.com ( [203.254.199.213]) by eucpsbgm1.samsung.com (EUCPMTA) with SMTP id 17.27.16778.BCAD6C65; Fri, 19 Feb 2016 09:05:15 +0000 (GMT) Received: from [106.109.129.180] by eusync3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0O2S00GCOEKQ7920@eusync3.samsung.com>; Fri, 19 Feb 2016 09:05:15 +0000 (GMT) To: "Xie, Huawei" , Yuanhan Liu References: <1455863563-15751-1-git-send-email-i.maximets@samsung.com> <1455863563-15751-5-git-send-email-i.maximets@samsung.com> <20160219071046.GT21426@yliu-dev.sh.intel.com> From: Ilya Maximets Message-id: <56C6DACA.7040109@samsung.com> Date: Fri, 19 Feb 2016 12:05:14 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-version: 1.0 In-reply-to: Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBLMWRmVeSWpSXmKPExsVy+t/xq7qnbx0LM9j7Xtri3aftTBbtM88y WUycZGIx/WmExeTZUhbXJ1xgdWDz2HCin9Xj14KlrB6L97xk8rhzbQ+bx7yTgR59W1YxBrBF cdmkpOZklqUW6dslcGUs3hJfsIav4v/rfqYGxjaeLkZODgkBE4kbm16xQthiEhfurWfrYuTi EBJYyiix5Og2JgjnBaPEwWN/mECqhAUiJRqaz7OD2CICoRJ9t5cxQhT9Y5Q4+fUJK4jDLDCX UeL3lBYWkCo2AR2JU6uPMILYvAJaEl1PToHtYxFQlfi75jRYjahAhMThzi52iBpBiR+T74HF OQXCJG71fATq5QAaqidx/6IWSJhZQF5i85q3zBMYBWYh6ZiFUDULSdUCRuZVjKKppckFxUnp uYZ6xYm5xaV56XrJ+bmbGCHh/WUH4+JjVocYBTgYlXh4LxgcCxNiTSwrrsw9xCjBwawkwqvr DxTiTUmsrEotyo8vKs1JLT7EKM3BoiTOO3fX+xAhgfTEktTs1NSC1CKYLBMHp1QDY+CtXPYa 1kd6z/f/aZzsbF1gW8V7fMfSZOZFOxarBfBWHzq5/ChvlsKbnVq9zWYbRf00K6W2vb53a2Pf LKmFUZe63Zgn7Y3q/TkrJu/e1veOUqcDitlmFOyvqdpizF338GL1q5dmTN56Lft3LV70tYtX iXfX7RaROX9yxZU5K+5VCF/gX7/khRJLcUaioRZzUXEiAK99oWVrAgAA Cc: "dev@dpdk.org" , Dyasly Sergey Subject: Re: [dpdk-dev] [PATCH RFC 4/4] doc: add note about rte_vhost_enqueue_burst thread safety. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Feb 2016 09:15:18 -0000 On 19.02.2016 11:36, Xie, Huawei wrote: > On 2/19/2016 3:10 PM, Yuanhan Liu wrote: >> On Fri, Feb 19, 2016 at 09:32:43AM +0300, Ilya Maximets wrote: >>> Signed-off-by: Ilya Maximets >>> --- >>> doc/guides/prog_guide/thread_safety_dpdk_functions.rst | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/doc/guides/prog_guide/thread_safety_dpdk_functions.rst b/doc/guides/prog_guide/thread_safety_dpdk_functions.rst >>> index 403e5fc..13a6c89 100644 >>> --- a/doc/guides/prog_guide/thread_safety_dpdk_functions.rst >>> +++ b/doc/guides/prog_guide/thread_safety_dpdk_functions.rst >>> @@ -67,6 +67,7 @@ then locking, or some other form of mutual exclusion, is necessary. >>> The ring library is based on a lockless ring-buffer algorithm that maintains its original design for thread safety. >>> Moreover, it provides high performance for either multi- or single-consumer/producer enqueue/dequeue operations. >>> The mempool library is based on the DPDK lockless ring library and therefore is also multi-thread safe. >>> +rte_vhost_enqueue_burst() is also thread safe because based on lockless ring-buffer algorithm like the ring library. >> FYI, Huawei meant to make rte_vhost_enqueue_burst() not be thread-safe, >> to aligh with the usage of rte_eth_tx_burst(). >> >> --yliu > > I have a patch to remove the lockless enqueue. Unless there is strong > reason, i prefer vhost PMD to behave like other PMDs, with no internal > lockless algorithm. In future, for people who really need it, we could > have dynamic/static switch to enable it. OK, got it. So, I think, this documentation patch may be dropped. Other patches of series still may be merged to fix existing issues and keep code in consistent state for the future. Am I right? Best regards, Ilya Maximets.