From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olivier.matz@6wind.com>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 0A096C54E
 for <dev@dpdk.org>; Fri, 19 Feb 2016 14:31:12 +0100 (CET)
Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214]
 helo=[192.168.0.10])
 by mail.droids-corp.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.84) (envelope-from <olivier.matz@6wind.com>)
 id 1aWlAh-0000MF-2Z; Fri, 19 Feb 2016 14:32:35 +0100
To: David Hunt <david.hunt@intel.com>, dev@dpdk.org
References: <1453829155-1366-1-git-send-email-david.hunt@intel.com>
 <1455634095-4183-1-git-send-email-david.hunt@intel.com>
 <1455634095-4183-3-git-send-email-david.hunt@intel.com>
From: Olivier MATZ <olivier.matz@6wind.com>
X-Enigmail-Draft-Status: N1110
Message-ID: <56C71919.50506@6wind.com>
Date: Fri, 19 Feb 2016 14:31:05 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Icedove/38.3.0
MIME-Version: 1.0
In-Reply-To: <1455634095-4183-3-git-send-email-david.hunt@intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 2/6] mempool: add stack (lifo) based external
 mempool handler
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Feb 2016 13:31:12 -0000

Hi David,

On 02/16/2016 03:48 PM, David Hunt wrote:
> adds a simple stack based mempool handler
> 
> Signed-off-by: David Hunt <david.hunt@intel.com>
> ---
>  lib/librte_mempool/Makefile            |   2 +-
>  lib/librte_mempool/rte_mempool.c       |   4 +-
>  lib/librte_mempool/rte_mempool.h       |   1 +
>  lib/librte_mempool/rte_mempool_stack.c | 164 +++++++++++++++++++++++++++++++++
>  4 files changed, 169 insertions(+), 2 deletions(-)
>  create mode 100644 lib/librte_mempool/rte_mempool_stack.c
> 

I don't get what is the purpose of this handler. Is it an example
or is it something that could be useful for dpdk applications?

If it's an example, we should find a way to put the code outside
the librte_mempool library, maybe in the test program. I see there
is also a "custom handler". Do we really need to have both?


Regards,
Olivier