From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 58E80201 for ; Tue, 23 Feb 2016 13:19:16 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP; 23 Feb 2016 04:19:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,489,1449561600"; d="scan'208";a="751613584" Received: from rhorton-mobl.ger.corp.intel.com (HELO [163.33.230.115]) ([163.33.230.115]) by orsmga003.jf.intel.com with ESMTP; 23 Feb 2016 04:19:14 -0800 Message-ID: <56CC4E41.4040109@intel.com> Date: Tue, 23 Feb 2016 12:19:13 +0000 From: Remy Horton Organization: Intel Shannon Limited User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Stephen Hemminger References: <1453970895-2639-1-git-send-email-remy.horton@intel.com> <20160216105452.0b1da99f@xeon-e3> In-Reply-To: <20160216105452.0b1da99f@xeon-e3> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v1 0/3] Add missing ethdev driver support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Feb 2016 12:19:16 -0000 On 16/02/2016 18:54, Stephen Hemminger wrote: > On Thu, 28 Jan 2016 08:48:12 +0000 > Remy Horton wrote: > >> Several rte_eth_dev_* functions are currently only supported >> by the ixgbe NIC driver. This patchset adds driver support >> for some of these functions to the i40e, virtio, and vmxnet3 >> drivers. > > It is good to make drivers more complete and compatible, but unless > the virtual driver has some useful data I can't see the point of providing > these functions in this case. The base infrastructure (rte_ethdev) should > deal with by returning not supported error (or all zeros); rather than > creating more code in other drivers for no real gain. Come to the same conclusion regarding the Rx/Tx queue info functions, as working out how to derive the figures I could return was also baking in some implicit assumptions. Plan to exclude those ones from the v2. ..Remy