From: Panu Matilainen <pmatilai@redhat.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: fix the combined library problems by replacing it with a linker script
Date: Wed, 24 Feb 2016 11:37:07 +0200 [thread overview]
Message-ID: <56CD79C3.5060701@redhat.com> (raw)
In-Reply-To: <1979393.TOkl0U0KRM@xps13>
On 02/23/2016 10:07 PM, Thomas Monjalon wrote:
> Hi,
>
> I'm reviving this old thread.
Thanks.
> My understanding is that everybody prefer the linker script
> than the current combined library which had neither symbol versioning
> nor library dependency informations.
Yeah it seemed to me most (if not everybody) had converged on the side
of the linker script approach.
>
> Comments below:
>
> 2015-11-24 16:31, Panu Matilainen:
>> The physically linked-together combined library has been an increasing
>> source of problems, as was predicted when library and symbol versioning
>> was introduced. Replace the complex and fragile construction with a
>> simple linker script which achieves the same without all the problems,
>> remove the related kludges from eg mlx drivers.
>>
>> Since creating the linker script is practically zero cost, remove the
>> config option and just create it always.
> [...]
>> --- /dev/null
>> +++ b/mk/rte.combinedlib.mk
>> @@ -0,0 +1,57 @@
>> +# BSD LICENSE
>> +#
>> +# Copyright(c) 2010-2015 Intel Corporation. All rights reserved.
>> +# All rights reserved.
>> +#
>> +# Redistribution and use in source and binary forms, with or without
>> +# modification, are permitted provided that the following conditions
>> +# are met:
>> +#
>> +# * Redistributions of source code must retain the above copyright
>> +# notice, this list of conditions and the following disclaimer.
>> +# * Redistributions in binary form must reproduce the above copyright
>> +# notice, this list of conditions and the following disclaimer in
>> +# the documentation and/or other materials provided with the
>> +# distribution.
>> +# * Neither the name of Intel Corporation nor the names of its
>> +# contributors may be used to endorse or promote products derived
>> +# from this software without specific prior written permission.
>
> Why this header, Panu?
> I think you should write your own copyright, and assume the linker script ;)
Its just inherited from the original patch by Sergio. As he's the actual
author here, it didn't seem appropriate for me to remove it.
>
> It needs to be rebased and some docs comments must be removed or updated.
> I'll send a v2.
>
Thanks,
- Panu -
next prev parent reply other threads:[~2016-02-24 9:37 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 14:31 Panu Matilainen
2015-11-24 14:55 ` Neil Horman
2015-11-24 21:28 ` Aaron Conole
2015-11-24 22:46 ` Stephen Hemminger
2015-11-25 8:38 ` Panu Matilainen
2015-11-25 13:00 ` Neil Horman
2015-11-25 16:08 ` Stephen Hemminger
2015-11-26 8:05 ` Panu Matilainen
2015-11-30 15:03 ` Neil Horman
2015-11-30 16:41 ` Stephen Hemminger
2015-12-01 12:21 ` Panu Matilainen
2015-12-01 12:36 ` Robie Basak
2015-12-01 13:30 ` Neil Horman
2015-12-08 17:03 ` Robie Basak
2015-12-09 14:16 ` Neil Horman
2015-12-01 13:20 ` Neil Horman
2015-12-01 12:37 ` Robie Basak
2015-12-02 11:44 ` Neil Horman
2015-12-03 1:31 ` Ferruh Yigit
2015-12-03 8:11 ` Christian Ehrhardt
2015-12-03 14:59 ` Neil Horman
2015-12-04 17:19 ` Thomas Monjalon
2015-12-07 8:27 ` Christian Ehrhardt
2015-12-07 10:33 ` Martinx - ジェームズ
2016-02-23 20:07 ` Thomas Monjalon
2016-02-24 9:37 ` Panu Matilainen [this message]
2016-02-23 22:20 ` [dpdk-dev] [PATCH v2] mk: replace the combined library " Thomas Monjalon
2016-03-01 13:40 ` Thomas Monjalon
2016-03-01 14:48 ` Panu Matilainen
2016-03-02 12:30 ` Panu Matilainen
2016-03-02 12:40 ` Thomas Monjalon
2016-03-02 12:44 ` Panu Matilainen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56CD79C3.5060701@redhat.com \
--to=pmatilai@redhat.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).