From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 0A6742BA2 for ; Wed, 24 Feb 2016 10:37:09 +0100 (CET) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 84D76627C9; Wed, 24 Feb 2016 09:37:08 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-7-116.ams2.redhat.com [10.36.7.116]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1O9b724016773; Wed, 24 Feb 2016 04:37:07 -0500 To: Thomas Monjalon References: <079fa1cfc3550c8147ea8b137fa1bc0f34d051dc.1448375477.git.pmatilai@redhat.com> <1979393.TOkl0U0KRM@xps13> From: Panu Matilainen Message-ID: <56CD79C3.5060701@redhat.com> Date: Wed, 24 Feb 2016 11:37:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: <1979393.TOkl0U0KRM@xps13> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 24 Feb 2016 09:37:08 +0000 (UTC) Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] mk: fix the combined library problems by replacing it with a linker script X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Feb 2016 09:37:09 -0000 On 02/23/2016 10:07 PM, Thomas Monjalon wrote: > Hi, > > I'm reviving this old thread. Thanks. > My understanding is that everybody prefer the linker script > than the current combined library which had neither symbol versioning > nor library dependency informations. Yeah it seemed to me most (if not everybody) had converged on the side of the linker script approach. > > Comments below: > > 2015-11-24 16:31, Panu Matilainen: >> The physically linked-together combined library has been an increasing >> source of problems, as was predicted when library and symbol versioning >> was introduced. Replace the complex and fragile construction with a >> simple linker script which achieves the same without all the problems, >> remove the related kludges from eg mlx drivers. >> >> Since creating the linker script is practically zero cost, remove the >> config option and just create it always. > [...] >> --- /dev/null >> +++ b/mk/rte.combinedlib.mk >> @@ -0,0 +1,57 @@ >> +# BSD LICENSE >> +# >> +# Copyright(c) 2010-2015 Intel Corporation. All rights reserved. >> +# All rights reserved. >> +# >> +# Redistribution and use in source and binary forms, with or without >> +# modification, are permitted provided that the following conditions >> +# are met: >> +# >> +# * Redistributions of source code must retain the above copyright >> +# notice, this list of conditions and the following disclaimer. >> +# * Redistributions in binary form must reproduce the above copyright >> +# notice, this list of conditions and the following disclaimer in >> +# the documentation and/or other materials provided with the >> +# distribution. >> +# * Neither the name of Intel Corporation nor the names of its >> +# contributors may be used to endorse or promote products derived >> +# from this software without specific prior written permission. > > Why this header, Panu? > I think you should write your own copyright, and assume the linker script ;) Its just inherited from the original patch by Sergio. As he's the actual author here, it didn't seem appropriate for me to remove it. > > It needs to be rebased and some docs comments must be removed or updated. > I'll send a v2. > Thanks, - Panu -