From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 2398D6CD4 for ; Mon, 29 Feb 2016 17:41:38 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 29 Feb 2016 08:41:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,521,1449561600"; d="scan'208";a="913644885" Received: from hlan2-mobl2.ccr.corp.intel.com (HELO [10.255.30.198]) ([10.255.30.198]) by fmsmga001.fm.intel.com with ESMTP; 29 Feb 2016 08:41:37 -0800 To: Panu Matilainen , dev@dpdk.org References: <1451544799-70776-1-git-send-email-jianfeng.tan@intel.com> <1456472067-2721-1-git-send-email-jianfeng.tan@intel.com> <1456472067-2721-2-git-send-email-jianfeng.tan@intel.com> <56D42CC4.4000100@redhat.com> From: "Tan, Jianfeng" Message-ID: <56D474C0.9090300@intel.com> Date: Tue, 1 Mar 2016 00:41:36 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56D42CC4.4000100@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 01/11] ethdev: add API to query packet type filling info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Feb 2016 16:41:39 -0000 Hi Panu, On 2/29/2016 7:34 PM, Panu Matilainen wrote: > On 02/26/2016 09:34 AM, Jianfeng Tan wrote: >> Add a new API rte_eth_dev_get_ptype_info to query whether/what packet >> type can be filled by given pmd rx burst function. >> >> Signed-off-by: Jianfeng Tan >> --- >> lib/librte_ether/rte_ethdev.c | 26 ++++++++++++++++++++++++++ >> lib/librte_ether/rte_ethdev.h | 26 ++++++++++++++++++++++++++ >> 2 files changed, 52 insertions(+) >> > [...] >> diff --git a/lib/librte_ether/rte_ethdev.h >> b/lib/librte_ether/rte_ethdev.h >> index 16da821..16f32a0 100644 >> --- a/lib/librte_ether/rte_ethdev.h >> +++ b/lib/librte_ether/rte_ethdev.h >> @@ -1021,6 +1021,9 @@ typedef void (*eth_dev_infos_get_t)(struct >> rte_eth_dev *dev, >> struct rte_eth_dev_info *dev_info); >> /**< @internal Get specific informations of an Ethernet device. */ >> >> +typedef const uint32_t *(*eth_dev_ptype_info_get_t)(struct >> rte_eth_dev *dev); >> +/**< @internal Get ptype info of eth_rx_burst_t. */ >> + >> typedef int (*eth_queue_start_t)(struct rte_eth_dev *dev, >> uint16_t queue_id); >> /**< @internal Start rx and tx of a queue of an Ethernet device. */ >> @@ -1347,6 +1350,7 @@ struct eth_dev_ops { >> eth_queue_stats_mapping_set_t queue_stats_mapping_set; >> /**< Configure per queue stat counter mapping. */ >> eth_dev_infos_get_t dev_infos_get; /**< Get device info. */ >> + eth_dev_ptype_info_get_t dev_ptype_info_get; /** Get ptype >> info */ >> mtu_set_t mtu_set; /**< Set MTU. */ >> vlan_filter_set_t vlan_filter_set; /**< Filter VLAN >> Setup. */ >> vlan_tpid_set_t vlan_tpid_set; /**< Outer VLAN >> TPID Setup. */ >> @@ -2268,6 +2272,28 @@ void rte_eth_macaddr_get(uint8_t port_id, >> struct ether_addr *mac_addr); > > Technically this is an ABI break but its marked internal and I guess > it falls into the "drivers only" territory similar to what was > discussed in this thead: > http://dpdk.org/ml/archives/dev/2016-January/032348.html so its > probably ok. Yes, I think so too. > >> void rte_eth_dev_info_get(uint8_t port_id, struct rte_eth_dev_info >> *dev_info); >> >> /** >> + * Retrieve the packet type information of an Ethernet device. >> + * >> + * @param port_id >> + * The port identifier of the Ethernet device. >> + * @param ptype_mask >> + * A hint of what kind of packet type which the caller is >> interested in. >> + * @param ptypes >> + * An array pointer to store adequent packet types, allocated by >> caller. >> + * @param num >> + * Size of the array pointed by param ptypes. >> + * @return >> + * - (>0) Number of ptypes supported. If it exceeds param num, >> exceeding >> + * packet types will not be filled in the given array. >> + * - (0 or -ENOTSUP) if PMD does not fill the specified ptype. >> + * - (-ENODEV) if *port_id* invalid. >> + */ >> +extern int rte_eth_dev_get_ptype_info(uint8_t port_id, >> + uint32_t ptype_mask, >> + uint32_t *ptypes, >> + int num); >> + >> +/** >> * Retrieve the MTU of an Ethernet device. >> * >> * @param port_id >> > > "extern" is redundant in headers. We just saw a round of removing them > (commit dd34ff1f0e03b2c5e4a97e9fbcba5c8238aac573), lets not add them > back :) > > More importantly, to export a function you need to add an entry for it > in rte_ether_version.map. Oh, yes, thanks for pointing out this, I'll change this and update rte_ether_version.map. Is it like this? Before or after DPDK_2.2 {}? DPDK_2.3 { global: rte_eth_dev_get_ptype_info; local: *; }; Thanks, Jianfeng > > - Panu - > >