From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 15BA49A81 for ; Tue, 1 Mar 2016 07:29:10 +0100 (CET) Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 50C2864D01; Tue, 1 Mar 2016 06:29:09 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-7-140.ams2.redhat.com [10.36.7.140]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u216T8bW021407; Tue, 1 Mar 2016 01:29:08 -0500 To: "Tan, Jianfeng" , dev@dpdk.org References: <1451544799-70776-1-git-send-email-jianfeng.tan@intel.com> <1456472067-2721-1-git-send-email-jianfeng.tan@intel.com> <1456472067-2721-2-git-send-email-jianfeng.tan@intel.com> <56D42CC4.4000100@redhat.com> <56D474C0.9090300@intel.com> From: Panu Matilainen Message-ID: <56D536B3.3080104@redhat.com> Date: Tue, 1 Mar 2016 08:29:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56D474C0.9090300@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 01 Mar 2016 06:29:09 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v5 01/11] ethdev: add API to query packet type filling info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Mar 2016 06:29:10 -0000 On 02/29/2016 06:41 PM, Tan, Jianfeng wrote: > Hi Panu, > > On 2/29/2016 7:34 PM, Panu Matilainen wrote: [...] >> >> More importantly, to export a function you need to add an entry for it >> in rte_ether_version.map. > > Oh, yes, thanks for pointing out this, I'll change this and update > rte_ether_version.map. > > Is it like this? Before or after DPDK_2.2 {}? > DPDK_2.3 { > global: > > rte_eth_dev_get_ptype_info; > > local: *; > }; Sorry I didn't have a chance to reply to this yesterday and I see you already posted a v6 with the above, which is almost but not quite there: it needs to inherit from DPDK_2.2, ie DPDK_2.3 { global: rte_eth_dev_get_ptype_info; local: *; } DPDK_2.2; ...but if there are no other reasons to respin the series perhaps Thomas can fixup that while applying. Then there's the actual version, which should optimally be DPDK_16.04 but that's purely cosmetical. There are a number of patches floating around with DPDK_2.3 {} and librte_eal actually has one on board, so clearly the dust from versioning change has not yet settled. - Panu - > > Thanks, > Jianfeng > >> >> - Panu - >> >> >