From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 8E1A22A6C for ; Tue, 1 Mar 2016 09:00:13 +0100 (CET) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP; 01 Mar 2016 00:00:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,522,1449561600"; d="scan'208";a="924089597" Received: from shwdeisgchi083.ccr.corp.intel.com (HELO [10.239.67.193]) ([10.239.67.193]) by orsmga002.jf.intel.com with ESMTP; 01 Mar 2016 00:00:08 -0800 To: Panu Matilainen , dev@dpdk.org, Thomas Monjalon References: <1451544799-70776-1-git-send-email-jianfeng.tan@intel.com> <1456472067-2721-1-git-send-email-jianfeng.tan@intel.com> <1456472067-2721-2-git-send-email-jianfeng.tan@intel.com> <56D42CC4.4000100@redhat.com> <56D474C0.9090300@intel.com> <56D536B3.3080104@redhat.com> From: "Tan, Jianfeng" Message-ID: <56D54C06.4020503@intel.com> Date: Tue, 1 Mar 2016 16:00:06 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56D536B3.3080104@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 01/11] ethdev: add API to query packet type filling info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Mar 2016 08:00:34 -0000 On 3/1/2016 2:29 PM, Panu Matilainen wrote: > On 02/29/2016 06:41 PM, Tan, Jianfeng wrote: >> Hi Panu, >> >> On 2/29/2016 7:34 PM, Panu Matilainen wrote: > [...] >>> >>> More importantly, to export a function you need to add an entry for it >>> in rte_ether_version.map. >> >> Oh, yes, thanks for pointing out this, I'll change this and update >> rte_ether_version.map. >> >> Is it like this? Before or after DPDK_2.2 {}? >> DPDK_2.3 { >> global: >> >> rte_eth_dev_get_ptype_info; >> >> local: *; >> }; > > Sorry I didn't have a chance to reply to this yesterday and I see you > already posted a v6 with the above, which is almost but not quite > there: it needs to inherit from DPDK_2.2, ie > > DPDK_2.3 { > global: > > rte_eth_dev_get_ptype_info; > > local: *; > } DPDK_2.2; > > ...but if there are no other reasons to respin the series perhaps > Thomas can fixup that while applying. OK, thanks. Should I add this new API into _API Changes_ section in doc/guides/rel_notes/release_16_04.rst? > > Then there's the actual version, which should optimally be DPDK_16.04 > but that's purely cosmetical. There are a number of patches floating > around with DPDK_2.3 {} and librte_eal actually has one on board, so > clearly the dust from versioning change has not yet settled. Maybe Thomas can give some advice here? DPDK_2.3 or DPDK_16.04 be used here? Thanks, Jianfeng > > - Panu - > >> >> Thanks, >> Jianfeng >> >>> >>> - Panu - >>> >>> >> >