Re: [dpdk-dev] [PATCH v2] mk: replace the combined library with a linker script

[Panu Matilainen <pmatilai@redhat.com>]

On 03/01/2016 03:40 PM, Thomas Monjalon wrote:
> ping
> I would like to be sure nothing is forgotten in this new revision.

Sorry, didn't realize you were waiting for input from me, it feels a bit 
strange to comment on something supposedly coming from myself :)

> 2016-02-23 23:20, Thomas Monjalon:
>> From: Panu Matilainen <pmatilai@redhat.com>
>>
>> The physically linked-together combined library has been an increasing
>> source of problems, as was predicted when library and symbol versioning
>> was introduced. Replace the complex and fragile construction with a
>> simple linker script which achieves the same without all the problems,
>> remove the related kludges from eg mlx drivers.
>>
>> Since creating the linker script is practically zero cost, remove the
>> config option and just create it always.
>>
>> Based on a patch by Sergio Gonzales Monroy, linker script approach
>> initially suggested by Neil Horman.
>>
>> Suggested-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
>> Suggested-by: Neil Horman <nhorman@tuxdriver.com>
>> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
>> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
>> ---
>> v2:
>> - move RTE_LIBNAME assignment rte.vars.mk to rte.combinedlib.mk
>> - update crypto
>> - update doc
>> - update rte.app.mk
>> - update test-build.sh
>

Briefly tested, gets generated and installed as it should etc - looks 
good to me.

	- Panu -