From: Zoltan Kiss <zoltan.kiss@linaro.org>
To: dev@dpdk.org
Subject: [dpdk-dev] ixgbe TX function selection
Date: Tue, 1 Mar 2016 19:18:31 +0000 [thread overview]
Message-ID: <56D5EB07.9070706@linaro.org> (raw)
Hi,
I've noticed that ixgbe_set_tx_function() selects the non-SG function
even if (dev->data->scattered_rx == 1). That seems a bit dangerous, as
you can turn that on inadvertently when you don't set max_rx_pkt_len and
buffer size in certain ways. I've learnt it in the hard way, as my
segmented packets were leaking memory on the TX path, which doesn't
cries if you send out segmented packets.
How should this case be treated? Assert on the non-SG TX side for the
'next' pointer? Or turning on SG if RX has it? It doesn't seem to be a
solid way as other interfaces still can have SG turned on.
Regards,
Zoltan
next reply other threads:[~2016-03-01 19:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 19:18 Zoltan Kiss [this message]
2016-03-04 1:47 ` Lu, Wenzhuo
2016-03-04 11:59 ` Zoltan Kiss
2016-03-10 7:51 ` Wu, Jingjing
2016-03-17 17:10 ` Zoltan Kiss
2016-03-18 0:45 ` Lu, Wenzhuo
2016-03-18 13:33 ` Zoltan Kiss
2016-03-19 15:46 ` Ananyev, Konstantin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D5EB07.9070706@linaro.org \
--to=zoltan.kiss@linaro.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).