From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 1B3AA2617
 for <dev@dpdk.org>; Wed,  2 Mar 2016 12:05:57 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga101.jf.intel.com with ESMTP; 02 Mar 2016 03:05:57 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,528,1449561600"; d="scan'208";a="899304599"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.70])
 ([10.237.220.70])
 by orsmga001.jf.intel.com with ESMTP; 02 Mar 2016 03:05:56 -0800
To: Stephen Hemminger <stephen@networkplumber.org>
References: <1456495841-15749-1-git-send-email-ferruh.yigit@intel.com>
 <1456846920-28770-1-git-send-email-ferruh.yigit@intel.com>
 <1456846920-28770-3-git-send-email-ferruh.yigit@intel.com>
 <20160301150631.4cf29e47@xeon-e3>
From: Ferruh Yigit <ferruh.yigit@intel.com>
X-Enigmail-Draft-Status: N1110
Message-ID: <56D6C913.8080806@intel.com>
Date: Wed, 2 Mar 2016 11:05:55 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.0
MIME-Version: 1.0
In-Reply-To: <20160301150631.4cf29e47@xeon-e3>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v4 2/4] kcp: add kernel control path kernel
 module
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 02 Mar 2016 11:05:58 -0000

On 3/1/2016 11:06 PM, Stephen Hemminger wrote:
> On Tue,  1 Mar 2016 15:41:58 +0000
> Ferruh Yigit <ferruh.yigit@intel.com> wrote:
> 
>> +#ifdef RTE_KCP_KO_DEBUG
>> +#define KCP_DBG(args...) pr_info(args)
>> +#else
>> +#define KCP_DBG(args...)
>> +#en
> 
> Why not use pr_debug() which is compile enabled already and supports dynamic
> enabling as well.
> 
Because of dynamic debug control, it is more complex and less known.
But I will update it to pr_debug.

Thanks,
ferruh