From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id F23DE9611 for ; Wed, 2 Mar 2016 13:44:52 +0100 (CET) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 64EE3804EB; Wed, 2 Mar 2016 12:44:52 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-4-227.ams2.redhat.com [10.36.4.227]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u22Ciosw012076; Wed, 2 Mar 2016 07:44:51 -0500 To: Thomas Monjalon References: <079fa1cfc3550c8147ea8b137fa1bc0f34d051dc.1448375477.git.pmatilai@redhat.com> <56D5ABB4.3010609@redhat.com> <56D6DCE0.3010501@redhat.com> <11773022.MfDspfNx6j@xps13> From: Panu Matilainen Message-ID: <56D6E042.6020902@redhat.com> Date: Wed, 2 Mar 2016 14:44:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <11773022.MfDspfNx6j@xps13> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] mk: replace the combined library with a linker script X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2016 12:44:53 -0000 On 03/02/2016 02:40 PM, Thomas Monjalon wrote: > 2016-03-02 14:30, Panu Matilainen: >> On 03/01/2016 04:48 PM, Panu Matilainen wrote: >>> On 03/01/2016 03:40 PM, Thomas Monjalon wrote: >>>> ping >>>> I would like to be sure nothing is forgotten in this new revision. >>> >>> Sorry, didn't realize you were waiting for input from me, it feels a bit >>> strange to comment on something supposedly coming from myself :) >>> >>>> 2016-02-23 23:20, Thomas Monjalon: >>>>> From: Panu Matilainen >>>>> >>>>> The physically linked-together combined library has been an increasing >>>>> source of problems, as was predicted when library and symbol versioning >>>>> was introduced. Replace the complex and fragile construction with a >>>>> simple linker script which achieves the same without all the problems, >>>>> remove the related kludges from eg mlx drivers. >>>>> >>>>> Since creating the linker script is practically zero cost, remove the >>>>> config option and just create it always. >>>>> >>>>> Based on a patch by Sergio Gonzales Monroy, linker script approach >>>>> initially suggested by Neil Horman. >>>>> >>>>> Suggested-by: Sergio Gonzalez Monroy >>>>> Suggested-by: Neil Horman >>>>> Signed-off-by: Panu Matilainen >>>>> Signed-off-by: Thomas Monjalon >>>>> --- >>>>> v2: >>>>> - move RTE_LIBNAME assignment rte.vars.mk to rte.combinedlib.mk >>>>> - update crypto >>>>> - update doc >>>>> - update rte.app.mk >>>>> - update test-build.sh >>>> >>> >>> Briefly tested, gets generated and installed as it should etc - looks >>> good to me. >> >> Forgot to note that the patch doesn't apply anymore because of >> scripts/test-build.sh changes, so it needs a rebase. Want me to send a >> v3 or will you handle it when committing? >> >> On a related note, if this is about to go in then I'd rather have it >> sooner than later because it also conflicts with the LDLIBS fixing >> that's been slowly going on for months and months but been on hold >> lately, partly because of this hangup. > > Applied, thanks > Awesome, thank you! :) - Panu -