From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 364C32B9E for ; Thu, 3 Mar 2016 10:35:08 +0100 (CET) Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 9CEA4C03E2; Thu, 3 Mar 2016 09:35:07 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-7-148.ams2.redhat.com [10.36.7.148]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u239Z6mc021865; Thu, 3 Mar 2016 04:35:06 -0500 To: Jasvinder Singh , dev@dpdk.org References: <1456757415-107819-1-git-send-email-jasvinder.singh@intel.com> <1456951307-35264-1-git-send-email-jasvinder.singh@intel.com> From: Panu Matilainen Message-ID: <56D80549.7070200@redhat.com> Date: Thu, 3 Mar 2016 11:35:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1456951307-35264-1-git-send-email-jasvinder.singh@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 Subject: Re: [dpdk-dev] [PATCH v3 1/2] librte_pipeline: add support for packet redirection at action handlers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Mar 2016 09:35:08 -0000 On 03/02/2016 10:41 PM, Jasvinder Singh wrote: > Currently, there is no mechanism that allows the pipeline ports (in/out) and > table action handlers to override the default forwarding decision (as > previously configured per input port or in the table entry). Therefore, new > pipeline API functions have been added which allows action handlers to > hijack packets and remove them from the pipeline processing, and then either > drop them or send them out of the pipeline on any output port. The port > (in/out) and table action handler prototypes have been changed for making > use of these new API functions. This feature will be helpful to implement > functions such as exception handling (e.g. TTL =0), load balancing etc. > > Signed-off-by: Jasvinder Singh > Acked-by: Cristian Dumitrescu > --- > v3 > * improved comments in "rte_pipeline.h" > > v2 > * rebased on master > > doc/guides/rel_notes/deprecation.rst | 5 - > doc/guides/rel_notes/release_16_04.rst | 6 +- > lib/librte_pipeline/Makefile | 4 +- > lib/librte_pipeline/rte_pipeline.c | 461 ++++++++++++++------------- > lib/librte_pipeline/rte_pipeline.h | 174 ++++++---- > lib/librte_pipeline/rte_pipeline_version.map | 8 + > 6 files changed, 362 insertions(+), 296 deletions(-) > [...] This causes a build failure: == Build app/test-pipeline CC pipeline_stub.o /srv/work/repos/dpdk/app/test-pipeline/pipeline_stub.c: In function ‘app_main_loop_worker_pipeline_stub’: /srv/work/repos/dpdk/app/test-pipeline/pipeline_stub.c:97:4: error: unknown field ‘f_action_bulk’ specified in initializer .f_action_bulk = NULL, ^ /srv/work/repos/dpdk/mk/internal/rte.compile-pre.mk:126: recipe for target 'pipeline_stub.o' failed Each individual commit needs to be buildable. Since its simply an incompatible API change, I guess there's no other way than updating the test app(s) in the same commit as the library. The other alternative would be temporarily disabling the test app(s) in the previous commit but that doesn't seem any better to me. - Panu -