From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ernst.netinsight.se (ernst.netinsight.se [194.16.221.21]) by dpdk.org (Postfix) with SMTP id 9F47E2B94 for ; Thu, 3 Mar 2016 11:22:55 +0100 (CET) Received: from [10.100.1.152] (unverified [10.100.1.152]) by ernst.netinsight.se (EMWAC SMTPRS 0.83) with SMTP id ; Thu, 03 Mar 2016 11:22:49 +0100 To: Thomas Monjalon , Stephen Hurd References: <1456954614-119304-1-git-send-email-stephen.hurd@broadcom.com> <1456978137-98097-2-git-send-email-stephen.hurd@broadcom.com> <56D7ED89.8060903@netinsight.net> <2201521.3lr0Br3EYS@xps13> From: =?UTF-8?Q?Simon_K=c3=a5gstr=c3=b6m?= Message-ID: <56D81079.4030905@netinsight.net> Date: Thu, 3 Mar 2016 11:22:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <2201521.3lr0Br3EYS@xps13> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 1/7] lib/librte_ether: Add 2/2.5/25/50Gbps link speeds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Mar 2016 10:22:55 -0000 On 2016-03-03 10:28, Thomas Monjalon wrote: > 2016-03-03 08:53, Simon Kågström: >> I realize this is a more general question, but is it really meaningful >> to have macros for all possible link speeds? We're working on a PMD >> driver with a channelized interface exposed as DPDK ports. Each channel >> can be configured with an arbitrary speed, so e.g., 1337 Mbps is also >> possible. > > What is the benefit? Why not negotiate the maximum capability of the peer? Communication is channelized over a backplane, and each channel has a specific (and configurable) capacity. >> To me, it would seem more natural to just have a number in mbits for the >> link speed. > > Please jump in the thread initiated by Marc Sune months ago. OK. I haven't been following the DPDK mailing list for a while, so I wasn't aware of this. // Simon