From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 80A4E2B94 for ; Thu, 3 Mar 2016 11:53:19 +0100 (CET) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 06CD4C00F5C9; Thu, 3 Mar 2016 10:53:19 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-7-148.ams2.redhat.com [10.36.7.148]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u23ArHK2025401; Thu, 3 Mar 2016 05:53:18 -0500 To: Thomas Monjalon References: <9190554.3JBlDK3N1R@xps13> <1456928543-23329-1-git-send-email-thomas.monjalon@6wind.com> <20160302220453.GE8804@bricha3-MOBL3> <3110515.Sqe0BZWodk@xps13> From: Panu Matilainen Message-ID: <56D8179D.8070905@redhat.com> Date: Thu, 3 Mar 2016 12:53:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <3110515.Sqe0BZWodk@xps13> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3] mk: stop on warning only in developer build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Mar 2016 10:53:19 -0000 On 03/03/2016 12:36 PM, Thomas Monjalon wrote: > 2016-03-02 22:04, Bruce Richardson: >> On Wed, Mar 02, 2016 at 03:22:23PM +0100, Thomas Monjalon wrote: >>> From: Panu Matilainen >>> >>> Add RTE_DEVEL_BUILD make-variable which can be used to do things >>> differently when doing development vs building a release, >>> autodetected from source root .git presence and overridable via >>> commandline. It is used it to enable -Werror compiler flag and may >>> be extended to other checks. >>> >>> Failing build on warnings is a useful developer tool but its bad >>> for release tarballs which can and do get built with newer >>> compilers than what was used/available during development. Compilers >>> routinely add new warnings so code which built silently with cc X >>> might no longer do so with X+1. This doesn't make the existing code >>> any more buggier and failing the build in this case does not help >>> to improve the quality of an already released version either. >>> >>> This change the default flags which can be tuned with EXTRA_CFLAGS. >>> >>> Signed-off-by: Panu Matilainen >>> Signed-off-by: Thomas Monjalon >> >> Acked-by: Bruce Richardson > > Applied, thanks Thanks for dusting this up, I'd pretty much forgotten the whole thing. - Panu -