From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 700A52BD3 for ; Fri, 4 Mar 2016 10:19:04 +0100 (CET) Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214] helo=[192.168.0.10]) by mail.droids-corp.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84) (envelope-from ) id 1abluT-0008QS-9z; Fri, 04 Mar 2016 10:20:34 +0100 To: Paul Emmerich , dev@dpdk.org References: <1455555325-20046-1-git-send-email-emmericp@net.in.tum.de> <1455555325-20046-2-git-send-email-emmericp@net.in.tum.de> From: Olivier MATZ X-Enigmail-Draft-Status: N1110 Message-ID: <56D95301.9050209@6wind.com> Date: Fri, 4 Mar 2016 10:18:57 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: <1455555325-20046-2-git-send-email-emmericp@net.in.tum.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/3] add tx crc disable flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Mar 2016 09:19:04 -0000 Hi Paul, On 02/15/2016 05:55 PM, Paul Emmerich wrote: > Signed-off-by: Paul Emmerich > --- > lib/librte_mbuf/rte_mbuf.c | 1 + > lib/librte_mbuf/rte_mbuf.h | 6 ++++++ > 2 files changed, 7 insertions(+) > > diff --git a/lib/librte_mbuf/rte_mbuf.c b/lib/librte_mbuf/rte_mbuf.c > index f506517..744fb4e 100644 > --- a/lib/librte_mbuf/rte_mbuf.c > +++ b/lib/librte_mbuf/rte_mbuf.c > @@ -270,6 +270,7 @@ const char *rte_get_rx_ol_flag_name(uint64_t mask) > const char *rte_get_tx_ol_flag_name(uint64_t mask) > { > switch (mask) { > + case PKT_TX_NO_CRC_CSUM: return "PKT_TX_NO_CRC_CSUM"; > case PKT_TX_VLAN_PKT: return "PKT_TX_VLAN_PKT"; > case PKT_TX_IP_CKSUM: return "PKT_TX_IP_CKSUM"; > case PKT_TX_TCP_CKSUM: return "PKT_TX_TCP_CKSUM"; > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h > index ab6de67..096d84a 100644 > --- a/lib/librte_mbuf/rte_mbuf.h > +++ b/lib/librte_mbuf/rte_mbuf.h > @@ -106,6 +106,12 @@ extern "C" { > /* add new TX flags here */ > > /** > + * Disable CRC checksum offload > + */ > +#define PKT_TX_NO_CRC_CSUM (1ULL << 49) > + > + > +/** > * TCP segmentation offload. To enable this offload feature for a > * packet to be transmitted on hardware supporting TSO: > * - set the PKT_TX_TCP_SEG flag in mbuf->ol_flags (this flag implies > The patch does not apply properly. It seems you've done it on a version that is more than 6 months old. Could you please rebase it? My second question concerns the behavior of this flag when it is not supported by the driver. Shouldn't we have a feature flag saying "this driver supports CRC stripping"? Also, I think "PKT_TX_STRIP_CRC" would be a better name. Regards, Olivier