From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pmatilai@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 2F71F1396
 for <dev@dpdk.org>; Fri,  4 Mar 2016 10:39:03 +0100 (CET)
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
 (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
 by mx1.redhat.com (Postfix) with ESMTPS id A348A7208C;
 Fri,  4 Mar 2016 09:39:02 +0000 (UTC)
Received: from sopuli.koti.laiskiainen.org (vpn1-5-73.ams2.redhat.com
 [10.36.5.73])
 by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 u249d1wK023509; Fri, 4 Mar 2016 04:39:01 -0500
To: "Traynor, Kevin" <kevin.traynor@intel.com>,
 Thomas Monjalon <thomas.monjalon@6wind.com>,
 "Wiles, Keith" <keith.wiles@intel.com>
References: <1456149217-24833-1-git-send-email-keith.wiles@intel.com>
 <121442835.2vdhmXQbJs@xps13>
 <BC0FEEC7D7650749874CEC11314A88F7454364C5@IRSMSX104.ger.corp.intel.com>
From: Panu Matilainen <pmatilai@redhat.com>
Message-ID: <56D957B4.4090104@redhat.com>
Date: Fri, 4 Mar 2016 11:39:00 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <BC0FEEC7D7650749874CEC11314A88F7454364C5@IRSMSX104.ger.corp.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.38]); Fri, 04 Mar 2016 09:39:02 +0000 (UTC)
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] config: remove duplicate configuration
 information
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Mar 2016 09:39:03 -0000

On 03/04/2016 11:28 AM, Traynor, Kevin wrote:
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
>> Sent: Thursday, March 3, 2016 6:38 PM
>> To: Wiles, Keith <keith.wiles@intel.com>
>> Cc: dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH] config: remove duplicate configuration
>> information
>>
>> 2016-02-22 07:53, Keith Wiles:
>>> --- /dev/null
>>> +++ b/config/common_base
>>> +CONFIG_RTE_EAL_IGB_UIO=y
>>> +CONFIG_RTE_EAL_VFIO=y
>>
>> These options should be disabled in the base file
>> and enabled in Linux.
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

>>
>>> +CONFIG_RTE_LIBRTE_PMD_AF_PACKET=y
>>
>> Idem, it should be disabled.
>>
>>> +CONFIG_RTE_LIBRTE_POWER=y
>>
>> Idem?
>>
>>> +CONFIG_RTE_LIBRTE_KNI=y
>>
>> Should be disabled.
>>
>>> +CONFIG_RTE_LIBRTE_VHOST=y
>>
>> Should be disabled.
>
> Any reason this should be disabled? It was changed to =Y in DPDK 2.1.

That's what I first thought too, but I think Thomas meant "disable in 
common_base, enable in Linux config" for all these.

	- Panu -