From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pmatilai@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id 91F382BD7
 for <dev@dpdk.org>; Fri,  4 Mar 2016 11:12:27 +0100 (CET)
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
 (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
 by mx1.redhat.com (Postfix) with ESMTPS id 93BFE2DC363;
 Fri,  4 Mar 2016 10:12:26 +0000 (UTC)
Received: from sopuli.koti.laiskiainen.org (vpn1-5-73.ams2.redhat.com
 [10.36.5.73])
 by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id
 u24ACPdT016051; Fri, 4 Mar 2016 05:12:25 -0500
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
 Keith Wiles <keith.wiles@intel.com>
References: <1456149217-24833-1-git-send-email-keith.wiles@intel.com>
 <121442835.2vdhmXQbJs@xps13>
From: Panu Matilainen <pmatilai@redhat.com>
Message-ID: <56D95F88.2000708@redhat.com>
Date: Fri, 4 Mar 2016 12:12:24 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <121442835.2vdhmXQbJs@xps13>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] config: remove duplicate configuration
 information
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Mar 2016 10:12:27 -0000

On 03/03/2016 08:37 PM, Thomas Monjalon wrote:
>> --- a/config/defconfig_x86_64-native-bsdapp-clang
>> +++ b/config/defconfig_x86_64-native-bsdapp-clang
>> @@ -37,6 +37,7 @@ CONFIG_RTE_MACHINE="native"
>>   CONFIG_RTE_ARCH="x86_64"
>>   CONFIG_RTE_ARCH_X86_64=y
>>   CONFIG_RTE_ARCH_X86=y
>> +CONFIG_RTE_ARCH_64=y
>>
>>   CONFIG_RTE_TOOLCHAIN="clang"
>>   CONFIG_RTE_TOOLCHAIN_CLANG=y
>> diff --git a/config/defconfig_x86_64-native-bsdapp-gcc b/config/defconfig_x86_64-native-bsdapp-gcc
>> index 5a6a4e8..4ea4433 100644
>> --- a/config/defconfig_x86_64-native-bsdapp-gcc
>> +++ b/config/defconfig_x86_64-native-bsdapp-gcc
>> @@ -37,6 +37,7 @@ CONFIG_RTE_MACHINE="native"
>>   CONFIG_RTE_ARCH="x86_64"
>>   CONFIG_RTE_ARCH_X86_64=y
>>   CONFIG_RTE_ARCH_X86=y
>> +CONFIG_RTE_ARCH_64=y
>
> It should be a totally separate patch.
> And there are other places where it is missing.

On a related note, perhaps the arch settings should be split to their 
own files, eg common_x86_64, common_i686 and so on that the defconfig 
files then include. That should eliminate things like missing 
CONFIG_RTE_ARCH_64 fairly effectively, and further reduce the 
duplication in the configs.

I can send a patch to do that once the dust from the common_base move 
settles if you like the idea.

	- Panu -