From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by dpdk.org (Postfix) with ESMTP id 6BF482BF7
 for <dev@dpdk.org>; Sun,  6 Mar 2016 02:11:56 +0100 (CET)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga104.fm.intel.com with ESMTP; 05 Mar 2016 17:11:55 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.22,543,1449561600"; d="scan'208";a="664506697"
Received: from jjlynch-mobl1.ger.corp.intel.com (HELO [10.252.19.82])
 ([10.252.19.82])
 by FMSMGA003.fm.intel.com with ESMTP; 05 Mar 2016 17:11:54 -0800
To: Thomas Monjalon <thomas.monjalon@6wind.com>,
 Keith Wiles <keith.wiles@intel.com>
References: <121442835.2vdhmXQbJs@xps13>
 <1457115072-68430-1-git-send-email-keith.wiles@intel.com>
 <1982157.64YrbiQtVx@xps13>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <56DB83D9.3030009@intel.com>
Date: Sun, 6 Mar 2016 01:11:53 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <1982157.64YrbiQtVx@xps13>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] config: remove duplicate configuration
 information
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Mar 2016 01:11:57 -0000

On 3/4/2016 10:43 PM, Thomas Monjalon wrote:
> 2016-03-04 12:11, Keith Wiles:
>> In order to cleanup the configuration files some and reduce
>> the number of duplicate configuration information. Add a new
>> file called common_base which contains just about all of the
>> configuration lines in one place. Then have the common_bsdapp,
>> common_linuxapp files include this one file. Then in those OS
>> specific files add the delta configuration lines.
>>
>> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
> 
> It's also fixing the crypto settings which were mispelled for BSD.
> 
> Applied with few cosmetic adjustments, thanks.
> 
This is already applied, but,

Is it required to keep Linux specific features
(igb_uio/vfio/kni/vhost..) in base config? Why not move all to Linux
only config?

Because they show up in final bsd config, which is unnecessary. Also
they show up in final Linux config twice, first one disables feature and
second one enables back. Although this works fine both for bsd and
Linux, it is confusing.

I will send a patch for this.

Thanks,
ferruh