From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 524572BF4 for ; Mon, 7 Mar 2016 18:06:23 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 07 Mar 2016 09:06:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,552,1449561600"; d="scan'208";a="665280220" Received: from rhorton-mobl.ger.corp.intel.com (HELO [163.33.229.120]) ([163.33.229.120]) by FMSMGA003.fm.intel.com with ESMTP; 07 Mar 2016 09:06:21 -0800 Message-ID: <56DDB50C.5040203@intel.com> Date: Mon, 07 Mar 2016 17:06:20 +0000 From: Remy Horton Organization: Intel Shannon Limited User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Stephen Hemminger References: <1457105124-23650-1-git-send-email-remy.horton@intel.com> <1457105124-23650-3-git-send-email-remy.horton@intel.com> <20160304123452.047709c2@xeon-e3> <56DD7365.7050002@intel.com> <20160307080747.02cc1f1b@xeon-e3> In-Reply-To: <20160307080747.02cc1f1b@xeon-e3> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2 2/2] drivers/net/vmxnet3: add ethdev functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Mar 2016 17:06:23 -0000 On 07/03/2016 16:07, Stephen Hemminger wrote: >> That version doesn't include a MAC address sanity check - is such a >> check redundant (or incorrect) in this case? >> >> ..Remy > > That belongs in common code, not in each driver. That differs from previous feedback for a different driver, where such a check was actually asked to be added.. :/ Probably need to audit the upstream functions for such checks. ..Remy