DPDK patches and discussions
 help / color / mirror / Atom feed
From: Olivier MATZ <olivier.matz@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
	Stephen Hemminger <stephen@networkplumber.org>,
	dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH, v2] mempool: avoid memory waste with large pagesize
Date: Thu, 10 Mar 2016 12:12:12 +0100	[thread overview]
Message-ID: <56E1568C.5020805@6wind.com> (raw)
In-Reply-To: <56E150FD.2090403@intel.com>

>> It still does not work. When CONFIG_RTE_LIBRTE_MEMPOOL_DEBUG=y:
>>
>> mp = rte_mempool_create("test", 128,
>> 	64, 0, 0, NULL, NULL, NULL, NULL, SOCKET_ID_ANY, 0);
>> rte_mempool_dump(stdout, mp);
>>
>>   populated_size=128
>>   header_size=64
>>   elt_size=64
>>   trailer_size=64
>>   total_obj_size=192
>>
> With --no-huge (since patch updates that part), it gives:
>   header_size=64
>   elt_size=64
>   trailer_size=0
>   total_obj_size=128
>   private_data_size=3904
> 
> 1- private_data still rounds to page size, not sure if this is a problem.
> 2- with MEMPOOL_DEBUG=y, trailer_size is 0, comment in code says it
> should keep cookie, not sure if this is a problem.

Yes the trailer should at least be 8 bytes to store the cookie.

  reply	other threads:[~2016-03-10 11:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-09 21:12 Stephen Hemminger
2016-03-10  8:37 ` Olivier MATZ
2016-03-10 10:48   ` Ferruh Yigit
2016-03-10 11:12     ` Olivier MATZ [this message]
2016-03-11  4:09       ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56E1568C.5020805@6wind.com \
    --to=olivier.matz@6wind.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).