From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 5BC822BCE for ; Thu, 10 Mar 2016 13:52:54 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP; 10 Mar 2016 04:52:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,315,1455004800"; d="scan'208";a="667029366" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.221.48]) ([10.237.221.48]) by FMSMGA003.fm.intel.com with ESMTP; 10 Mar 2016 04:52:31 -0800 To: Panu Matilainen , dev@dpdk.org References: From: Ferruh Yigit Message-ID: <56E16E0E.9090703@intel.com> Date: Thu, 10 Mar 2016 12:52:30 +0000 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 1/3] scripts: support parallel building in validate-abi.sh via -j[N] option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Mar 2016 12:52:54 -0000 On 3/10/2016 10:53 AM, Panu Matilainen wrote: > Signed-off-by: Panu Matilainen > --- > doc/guides/contributing/versioning.rst | 4 +++- > scripts/validate-abi.sh | 13 ++++++++++--- > 2 files changed, 13 insertions(+), 4 deletions(-) > > diff --git a/doc/guides/contributing/versioning.rst b/doc/guides/contributing/versioning.rst > index ae10a98..33b03a1 100644 > --- a/doc/guides/contributing/versioning.rst > +++ b/doc/guides/contributing/versioning.rst > @@ -469,11 +469,13 @@ utilities which can be installed via a package manager. For example:: > > The syntax of the ``validate-abi.sh`` utility is:: > > - ./scripts/validate-abi.sh > + ./scripts/validate-abi.sh [-j[N]] > > Where ``REV1`` and ``REV2`` are valid gitrevisions(7) > https://www.kernel.org/pub/software/scm/git/docs/gitrevisions.html > on the local repo and target is the usual DPDK compilation target. > +The optional -j[N] switch enables parallel building with at most > +N simultaneous jobs, ie the same as -j option of ``make``. > > For example: > > diff --git a/scripts/validate-abi.sh b/scripts/validate-abi.sh > index c36ad61..f094582 100755 > --- a/scripts/validate-abi.sh > +++ b/scripts/validate-abi.sh > @@ -27,13 +27,20 @@ > # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > > +case "$1" in > + -j*) > + MAKEJOBS="$1" > + shift > + ;; > +esac > + > TAG1=$1 > TAG2=$2 > TARGET=$3 > ABI_DIR=`mktemp -d -p /tmp ABI.XXXXXX` > > usage() { > - echo "$0 " > + echo "$0 [-j[N]] " > } > > log() { > @@ -183,7 +190,7 @@ log "INFO" "Configuring DPDK $TAG1" > make config T=$TARGET O=$TARGET > $VERBOSE 2>&1 > > log "INFO" "Building DPDK $TAG1. This might take a moment" > -make O=$TARGET > $VERBOSE 2>&1 > +make $MAKEJOBS O=$TARGET > $VERBOSE 2>&1 > > if [ $? -ne 0 ] > then > @@ -214,7 +221,7 @@ log "INFO" "Configuring DPDK $TAG2" > make config T=$TARGET O=$TARGET > $VERBOSE 2>&1 > > log "INFO" "Building DPDK $TAG2. This might take a moment" > -make O=$TARGET > $VERBOSE 2>&1 > +make $MAKEJOBS O=$TARGET > $VERBOSE 2>&1 > > if [ $? -ne 0 ] > then > This is something good to have. I also found following is also working, not sure if need to document in script: "MAKEFLAGS="-j32" ./validate-abi.sh X Y Z" And was just thinking if needs to address "-j N" usage (space after -j), it is your call. Other than this, Acked-by: Ferruh Yigit