From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vido@cesnet.cz>
Received: from office2.cesnet.cz (office2.cesnet.cz [195.113.144.244])
 by dpdk.org (Postfix) with ESMTP id C1BA9532C
 for <dev@dpdk.org>; Tue, 15 Mar 2016 14:50:52 +0100 (CET)
Received: from [IPv6:2001:67c:1220:8b2:e849:51b9:b39f:4866] (unknown
 [IPv6:2001:67c:1220:8b2:e849:51b9:b39f:4866])
 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 by office2.cesnet.cz (Postfix) with ESMTPSA id 950ECED5B1A;
 Tue, 15 Mar 2016 14:50:52 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cesnet.cz;
 s=office2; t=1458049852;
 bh=c0yOzjMNE5NLwKBr4Ea/kYG50oNsKIV7NsDAcsVXplo=;
 h=Subject:To:References:Cc:From:Message-ID:Date:MIME-Version:
 In-Reply-To:Content-Type:Content-Transfer-Encoding;
 b=Pii70aGN4KFDfRnTV6AUmH9rSblQR6mvAaERdu7lepOXfk1S36uXfiLhnmJjjUIrV
 ocGc7y+4gDDm/QBDlzu0rAiEFwV8DDgycTLAKugnk6QKYcxgc5rtKp1nCUydWxeDKU
 88A1ja93LmLo7ychbTxokrKuWRnXxsz5Z4wex3yY=
To: Thomas Monjalon <thomas.monjalon@6wind.com>
References: <1457992546-32230-1-git-send-email-thomas.monjalon@6wind.com>
 <1458047529-6522-1-git-send-email-vido@cesnet.cz>
 <1458047529-6522-5-git-send-email-vido@cesnet.cz> <8527284.jAONBlNGsn@xps13>
Cc: marcdevel@gmail.com, dev@dpdk.org
From: Matej Vido <vido@cesnet.cz>
Message-ID: <56E8133C.2020307@cesnet.cz>
Date: Tue, 15 Mar 2016 14:50:52 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <8527284.jAONBlNGsn@xps13>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH 4/4] szedata2: add 100G link speed
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Mar 2016 13:50:52 -0000



Dňa 15.03.2016 o 14:41 Thomas Monjalon napísal(a):
> Thanks for the series completing the ethdev rework with the same splitting.
>
> 2016-03-15 14:12, Matej Vido:
>> Temporary 10G constant is replaced with 100G constant.
>> Item speed_capa from struct rte_eth_dev_info is set with 100G flag.
> [...]
>> @@ -1161,7 +1162,7 @@ eth_link_update(struct rte_eth_dev *dev,
>>   		 * will be changed to support 100Gbps speed change
>>   		 * this value to 100G.
>>   		 */
>> -		link.link_speed = ETH_SPEED_NUM_10G;
>> +		link.link_speed = ETH_SPEED_NUM_100G;
> Shouldn't we remove the above comment?
Yes, I forgot. Should I remove the comment and send again or could you 
do it when merging with original series?

Matej