From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Panu Matilainen <pmatilai@redhat.com>, dev@dpdk.org
Cc: thomas.monjalon@6wind.com
Subject: Re: [dpdk-dev] [PATCH 2/2] mk: fix two more missing libm dependencies
Date: Mon, 21 Mar 2016 11:48:24 +0000 [thread overview]
Message-ID: <56EFDF88.2040309@intel.com> (raw)
In-Reply-To: <27d49a881875edbfdacbf8f621d38c3927a95881.1458560038.git.pmatilai@redhat.com>
On 3/21/2016 11:33 AM, Panu Matilainen wrote:
> Commit e86a699cf6b1 missed two further libm dependencies: ceil() used by
> librte_meter is typically inlined so the missing dependency does not
> actually cause failures, and librte_pmd_nfp is not built by default
> so its easy to miss.
>
> This causes duplicates in LDLIBS in many configurations so its vital
> they are removed before passing to linker.
>
> Fixes: e86a699cf6b1 ("mk: fix shared library dependencies on libm and librt")
>
> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
next prev parent reply other threads:[~2016-03-21 11:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 11:33 [dpdk-dev] [PATCH 1/2] mk: Eliminate possible duplicates from LDLIBS Panu Matilainen
2016-03-21 11:33 ` [dpdk-dev] [PATCH 2/2] mk: fix two more missing libm dependencies Panu Matilainen
2016-03-21 11:48 ` Ferruh Yigit [this message]
2016-03-22 19:39 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56EFDF88.2040309@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=pmatilai@redhat.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).