DPDK patches and discussions
 help / color / mirror / Atom feed
From: Olivier Matz <olivier.matz@6wind.com>
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>,
	bruce.richardson@intel.com, dev@dpdk.org
Cc: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [dpdk-dev] [PATCH 0/5] lpm allocation fixes - v3
Date: Mon, 21 Mar 2016 14:18:54 +0100	[thread overview]
Message-ID: <56EFF4BE.3070001@6wind.com> (raw)
In-Reply-To: <1458137793-25826-1-git-send-email-christian.ehrhardt@canonical.com>



On 03/16/2016 03:16 PM, Christian Ehrhardt wrote:
> Poking a bit on autotest revealed a few shortcomings in the lpm allocation path.
> Thanks to the feedback to the first revision of the patches here v2.
> Also Oliver Matz spotted similar issues and made me aware - thanks!
> Integrating them revealed even more use after free / leak issues.
> 
> *updates in v3*
> - lpm create/free path for v20 and v1604 got the same fixes that were
>   already identified for lpm6 before
> 
> *updates in v2*
> - lpm/lpm6 patches split
> - following dpdk coding guidelines regarding single line if's
> - adding singed-off and acked-bys gathered so far
> - combine all three related patches in one series
> 
> [PATCH 1/5] lpm6: fix use after free of lpm in rte_lpm6_create
> [PATCH 2/5] lpm6: fix missing free of rules_tbl and lpm
> [PATCH 3/5] lpm: fix missing free of lpm
> [PATCH 4/5] lpm: fix use after free of lpm in rte_lpm_create*
> [PATCH 5/5] lpm: fix missing free of rules_tbl and lpm in
> 
> diffstat:
>  rte_lpm.c  |   23 ++++++++++-------------
>  rte_lpm6.c |   12 ++++++------
>  2 files changed, 16 insertions(+), 19 deletions(-)
> 

Series
Acked-by: Olivier Matz <olivier.matz@6wind.com>

Just one small comment: there are additional { } in patches
2/5 and 3/5.

Thomas, do you think you can remove it while pushing?

  parent reply	other threads:[~2016-03-21 13:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-16 14:16 Christian Ehrhardt
2016-03-16 14:16 ` [dpdk-dev] [PATCH 1/5] lpm6: fix use after free of lpm in rte_lpm6_create Christian Ehrhardt
2016-03-16 14:16 ` [dpdk-dev] [PATCH 2/5] lpm6: fix missing free of rules_tbl and lpm Christian Ehrhardt
2016-03-16 14:16 ` [dpdk-dev] [PATCH 3/5] lpm: fix missing free of lpm Christian Ehrhardt
2016-03-16 14:16 ` [dpdk-dev] [PATCH 4/5] lpm: fix use after free of lpm in rte_lpm_create* Christian Ehrhardt
2016-03-16 14:16 ` [dpdk-dev] [PATCH 5/5] lpm: fix missing free of rules_tbl and lpm in rte_lpm_free* Christian Ehrhardt
2016-03-21 13:18 ` Olivier Matz [this message]
2016-03-21 14:02   ` [dpdk-dev] [PATCH 0/5] lpm allocation fixes - v3 Christian Ehrhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56EFF4BE.3070001@6wind.com \
    --to=olivier.matz@6wind.com \
    --cc=bruce.richardson@intel.com \
    --cc=christian.ehrhardt@canonical.com \
    --cc=dev@dpdk.org \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).