From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id BF6802BF3 for ; Mon, 21 Mar 2016 14:18:56 +0100 (CET) Received: by mail-wm0-f42.google.com with SMTP id r129so50117851wmr.1 for ; Mon, 21 Mar 2016 06:18:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=X6b6hDQusWVg2K+ADdW7h5bM/GZGti/JY1BBvmc3JLw=; b=DGnff+oF1hlrmqKT9HDVkHGo/1m4YIMJh4OzMBlnHiJbLpuXF13idxkyh4bSE6L96M hAUapz3lSvUHC/vD3ACrW/OOiW8vQXyvYr8X1k3TfTlpZ2kKqXniN3JIzJ/ZnDwiJSHt jQlgnPGKjBFeSvAyjgPXSjsLHercXZ4AUAbT4eTKHBnklwj678XE2o8MiVW2bb9t/dcu OEbcilkwGQEKQ8jKYb0GPaFsI64PPfmJOqts76uwcOhLFim1fAfcN3lwmp16GQL7eZJt UvJpY7SFee8/Ly6484loJJBjhOtAgTCwhZegD0elaFYcq6E2ckhGJY8xL95fljjwQLVH uSBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=X6b6hDQusWVg2K+ADdW7h5bM/GZGti/JY1BBvmc3JLw=; b=Egp7W905gNWZ5f6b5MXX0aQ0sUhYEnup10waAd3Zq7VsfkSVMNa+/LE+9Ri1aO16RC 2uJznBMHsL6S6K4ZzXRd42xj16+YRodAg/iTffU+9/GYo23gJlCkJ++HevTgHw5l88Jk G7CmbLxFlUrHnYHLP6NVOrVylwpmaRNBKgM9zFwsj+Bzj9U6dGuIAmitnX48WXQkCAcs /HQzTZKkTvxVHjWBgos8mR8/Pc0ooFicX1TCEJ4FnuEtxLMhws3lk6J+9e1O7HgIFoBY nXNfESpwApBd6ZQRyi0xgVZZCueooqT8WgKD+jT4CXx8lEZcJgHG99VGQM1j6l9RXzik iR+w== X-Gm-Message-State: AD7BkJL5H52RmTfMUZyHkWZkZ4xAGKEg24Jx+/um53z0a6jb1EaX6MTbre/av97XwfpNbshy X-Received: by 10.28.95.131 with SMTP id t125mr14497664wmb.80.1458566336612; Mon, 21 Mar 2016 06:18:56 -0700 (PDT) Received: from [192.168.0.10] (was59-1-82-226-113-214.fbx.proxad.net. [82.226.113.214]) by smtp.gmail.com with ESMTPSA id jo6sm25352183wjb.48.2016.03.21.06.18.55 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 21 Mar 2016 06:18:55 -0700 (PDT) To: Christian Ehrhardt , bruce.richardson@intel.com, dev@dpdk.org References: <1458137793-25826-1-git-send-email-christian.ehrhardt@canonical.com> Cc: Thomas Monjalon From: Olivier Matz Message-ID: <56EFF4BE.3070001@6wind.com> Date: Mon, 21 Mar 2016 14:18:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.6.0 MIME-Version: 1.0 In-Reply-To: <1458137793-25826-1-git-send-email-christian.ehrhardt@canonical.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 0/5] lpm allocation fixes - v3 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Mar 2016 13:18:56 -0000 On 03/16/2016 03:16 PM, Christian Ehrhardt wrote: > Poking a bit on autotest revealed a few shortcomings in the lpm allocation path. > Thanks to the feedback to the first revision of the patches here v2. > Also Oliver Matz spotted similar issues and made me aware - thanks! > Integrating them revealed even more use after free / leak issues. > > *updates in v3* > - lpm create/free path for v20 and v1604 got the same fixes that were > already identified for lpm6 before > > *updates in v2* > - lpm/lpm6 patches split > - following dpdk coding guidelines regarding single line if's > - adding singed-off and acked-bys gathered so far > - combine all three related patches in one series > > [PATCH 1/5] lpm6: fix use after free of lpm in rte_lpm6_create > [PATCH 2/5] lpm6: fix missing free of rules_tbl and lpm > [PATCH 3/5] lpm: fix missing free of lpm > [PATCH 4/5] lpm: fix use after free of lpm in rte_lpm_create* > [PATCH 5/5] lpm: fix missing free of rules_tbl and lpm in > > diffstat: > rte_lpm.c | 23 ++++++++++------------- > rte_lpm6.c | 12 ++++++------ > 2 files changed, 16 insertions(+), 19 deletions(-) > Series Acked-by: Olivier Matz Just one small comment: there are additional { } in patches 2/5 and 3/5. Thomas, do you think you can remove it while pushing?