Re: [dpdk-dev] [PATCH] testpmd: fix build on FreeBSD

[Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>]

On 22/03/2016 03:30, Liu, Yong wrote:
> Hi Pablo & Sergio,
>
>> -----Original Message-----
>> From: De Lara Guarch, Pablo
>> Sent: Monday, March 21, 2016 5:40 PM
>> To: Gonzalez Monroy, Sergio; Liu, Yong; dev@dpdk.org
>> Subject: RE: [dpdk-dev] [PATCH] testpmd: fix build on FreeBSD
>>
>>
>>
>>> -----Original Message-----
>>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Sergio Gonzalez
>>> Monroy
>>> Sent: Monday, March 21, 2016 9:13 AM
>>> To: Liu, Yong; dev@dpdk.org
>>> Subject: Re: [dpdk-dev] [PATCH] testpmd: fix build on FreeBSD
>>>
>>> On 21/03/2016 01:44, Marvin Liu wrote:
>>>> Build log:
>>>> /root/dpdk/app/test-pmd/cmdline.c:6687:45: error: no member named
>>>> 's6_addr32' in 'struct in6_addr'
>>>> 	rte_be_to_cpu_32(res->ip_value.addr.ipv6.s6_addr32[i]);
>>>>
>>>> This is caused by macro "s6_addr32" not defined on FreeBSD.
>>>>
>>>> Signed-off-by: Marvin Liu <yong.liu@intel.com>
>>>>
>>>> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
>>>> index 9d52b8c..51ad23b 100644
>>>> --- a/app/test-pmd/cmdline.c
>>>> +++ b/app/test-pmd/cmdline.c
>>>> @@ -6684,7 +6684,11 @@ cmd_tunnel_filter_parsed(void *parsed_result,
>>>>    		int i;
>>>>    		for (i = 0; i < 4; i++) {
>>>>    			tunnel_filter_conf.ip_addr.ipv6_addr[i] =
>>>> +#ifdef RTE_EXEC_ENV_BSDAPP
>>>> +			rte_be_to_cpu_32(res-
>>>> ip_value.addr.ipv6.__u6_addr.__u6_addr32[i]);
>>>> +#else
>>>>    			rte_be_to_cpu_32(res-
>>>> ip_value.addr.ipv6.s6_addr32[i]);
>>>> +#endif
>>> Why not always use .__u6_addr.__u6_addr32[i] and avoid ifdef?
>>>
> Because of structures between BSD an Linux have different names.
> On linux, it will be "__in6_u. __u6_addr32".

Duh!

Sorry about that. I should drink coffee before replying emails.

Sergio

>>> Sergio
>>>
>>>>    		}
>>>>    		tunnel_filter_conf.ip_type = RTE_TUNNEL_IPTYPE_IPV6;
>>>>    	}
>> Also, can you include the missing "Fixes" line?
>>
> Sure, I will add it and send out v2.
>
>> Thanks,
>> Pablo
> Best regards,
> Marvin
>