From: Panu Matilainen <pmatilai@redhat.com>
To: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] mk: fix eal shared library dependencies -lrt
Date: Tue, 22 Mar 2016 14:18:10 +0200 [thread overview]
Message-ID: <56F13802.60206@redhat.com> (raw)
In-Reply-To: <1458640699-8108-1-git-send-email-danielx.t.mrzyglod@intel.com>
On 03/22/2016 11:58 AM, Daniel Mrzyglod wrote:
> For GLIBC < 2.17 it is necessery to add -lrt for linker
> from glibc > 2.17 The `clock_*' suite of functions (declared in <time.h>) is now
> available directly in the main C library. This affect Ubuntu 12.04 in i686
> and other older Linux Distros).
>
> Fixes: 4758404a3084 ("mk: fix eal shared library dependencies")
>
> Signed-off-by: Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>
> ---
> app/test/Makefile | 1 +
> examples/ptpclient/Makefile | 1 +
> lib/librte_eal/linuxapp/eal/Makefile | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/app/test/Makefile b/app/test/Makefile
> index 00e4df2..707930f 100644
> --- a/app/test/Makefile
> +++ b/app/test/Makefile
> @@ -114,6 +114,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_CMDLINE) += test_cmdline_string.c
> SRCS-$(CONFIG_RTE_LIBRTE_CMDLINE) += test_cmdline_lib.c
>
> ifeq ($(CONFIG_RTE_LIBRTE_SCHED),y)
> +LDFLAGS += -lrt
> SRCS-y += test_red.c
> SRCS-y += test_sched.c
> endif
> diff --git a/examples/ptpclient/Makefile b/examples/ptpclient/Makefile
> index b77cf71..082c690 100644
> --- a/examples/ptpclient/Makefile
> +++ b/examples/ptpclient/Makefile
> @@ -46,6 +46,7 @@ SRCS-y := ptpclient.c
>
> CFLAGS += -O3
> CFLAGS += $(WERROR_FLAGS)
> +LDFLAGS += -lrt
These two should be LDLIBS instead. LDFLAGS is for passing in other
arguments to the linker, such as path, LDLIBS exists solely for passing
in the actual libraries.
- Panu -
next prev parent reply other threads:[~2016-03-22 12:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 8:09 [dpdk-dev] [PATCH] " Daniel Mrzyglod
2016-03-22 8:55 ` Thomas Monjalon
2016-03-22 9:25 ` Mrzyglod, DanielX T
2016-03-22 9:58 ` [dpdk-dev] [PATCH v2] " Daniel Mrzyglod
2016-03-22 12:18 ` Panu Matilainen [this message]
2016-03-22 12:49 ` Daniel Mrzyglod
2016-03-22 12:51 ` [dpdk-dev] [PATCH v3] " Daniel Mrzyglod
2016-03-22 19:47 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F13802.60206@redhat.com \
--to=pmatilai@redhat.com \
--cc=danielx.t.mrzyglod@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).