From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 4731329C6 for ; Tue, 22 Mar 2016 13:18:12 +0100 (CET) Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id B8BC46438E; Tue, 22 Mar 2016 12:18:11 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-7-110.ams2.redhat.com [10.36.7.110]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2MCIAhH002828; Tue, 22 Mar 2016 08:18:11 -0400 To: Daniel Mrzyglod , dev@dpdk.org References: <1458634142-10084-1-git-send-email-danielx.t.mrzyglod@intel.com> <1458640699-8108-1-git-send-email-danielx.t.mrzyglod@intel.com> From: Panu Matilainen Message-ID: <56F13802.60206@redhat.com> Date: Tue, 22 Mar 2016 14:18:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1458640699-8108-1-git-send-email-danielx.t.mrzyglod@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.26 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 22 Mar 2016 12:18:11 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v2] mk: fix eal shared library dependencies -lrt X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Mar 2016 12:18:12 -0000 On 03/22/2016 11:58 AM, Daniel Mrzyglod wrote: > For GLIBC < 2.17 it is necessery to add -lrt for linker > from glibc > 2.17 The `clock_*' suite of functions (declared in ) is now > available directly in the main C library. This affect Ubuntu 12.04 in i686 > and other older Linux Distros). > > Fixes: 4758404a3084 ("mk: fix eal shared library dependencies") > > Signed-off-by: Daniel Mrzyglod > --- > app/test/Makefile | 1 + > examples/ptpclient/Makefile | 1 + > lib/librte_eal/linuxapp/eal/Makefile | 1 + > 3 files changed, 3 insertions(+) > > diff --git a/app/test/Makefile b/app/test/Makefile > index 00e4df2..707930f 100644 > --- a/app/test/Makefile > +++ b/app/test/Makefile > @@ -114,6 +114,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_CMDLINE) += test_cmdline_string.c > SRCS-$(CONFIG_RTE_LIBRTE_CMDLINE) += test_cmdline_lib.c > > ifeq ($(CONFIG_RTE_LIBRTE_SCHED),y) > +LDFLAGS += -lrt > SRCS-y += test_red.c > SRCS-y += test_sched.c > endif > diff --git a/examples/ptpclient/Makefile b/examples/ptpclient/Makefile > index b77cf71..082c690 100644 > --- a/examples/ptpclient/Makefile > +++ b/examples/ptpclient/Makefile > @@ -46,6 +46,7 @@ SRCS-y := ptpclient.c > > CFLAGS += -O3 > CFLAGS += $(WERROR_FLAGS) > +LDFLAGS += -lrt These two should be LDLIBS instead. LDFLAGS is for passing in other arguments to the linker, such as path, LDLIBS exists solely for passing in the actual libraries. - Panu -