From: Markos Chandras <mchandras@suse.de>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mk: toolchain: gcc: query the compiler macros to obtain the gcc version
Date: Wed, 23 Mar 2016 09:56:02 +0000 [thread overview]
Message-ID: <56F26832.8020805@suse.de> (raw)
In-Reply-To: <10969139.eXE434OmqC@xps13>
On 03/23/2016 09:49 AM, Thomas Monjalon wrote:
> 2016-03-22 22:50, Markos Chandras:
>> On 22/03/16 22:34, Thomas Monjalon wrote:
>>> 2016-03-22 17:13, Markos Chandras:
>>>> This is similar to what's being used in the Linux kernel. Querying the
>>>> GCC macros directly gives more accurate results compared to -dumpversion
>>>> which could vary across distributions.
>>>>
>>>> Signed-off-by: Markos Chandras <mchandras@suse.de>
>>>> ---
>>>> In openSUSE Tumbleweed (and in any other SUSE distribution which
>>>> uses (or will use) gcc >= 5), gcc -dumpversion returns '5'. This is on
>>>> purpose as discussed in https://bugzilla.opensuse.org/show_bug.cgi?id=941428
>>>
>>> Good to know. It could be in the commit log.
>>
>> I can add this information to the commit message and send a v2 if needed.
>
> I will apply with this info.
Thank you Thomas.
--
markos
next prev parent reply other threads:[~2016-03-23 9:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 17:13 Markos Chandras
2016-03-22 22:34 ` Thomas Monjalon
2016-03-22 22:50 ` Markos Chandras
2016-03-23 9:49 ` Thomas Monjalon
2016-03-23 9:56 ` Markos Chandras [this message]
2016-03-23 10:00 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F26832.8020805@suse.de \
--to=mchandras@suse.de \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).