Re: [dpdk-dev] [PATCH] mlx4: use dummy rxqs when a non-pow2 number is requested

[Olivier Matz <olivier.matz@6wind.com>]

Hi Bruce,

On 03/24/2016 01:20 PM, Bruce Richardson wrote:
>> @@ -734,12 +734,12 @@ dev_configure(struct rte_eth_dev *dev)
>>  	}
>>  	if (rxqs_n == priv->rxqs_n)
>>  		return 0;
>> -	if ((rxqs_n & (rxqs_n - 1)) != 0) {
>> -		ERROR("%p: invalid number of RX queues (%u),"
>> -		      " must be a power of 2",
>> +	if (!rte_is_power_of_2(rxqs_n)) {
>> +		WARN("%p: number of RX queues (%u), must be a"
>> +		      " power of 2: remaining queues will be inactive",
> 
> I'm not sure how clear this warning message is. To the reader there are no
> extra "remaining" queues referred to, as it's not stated that the driver is
> allocating extra queues. How about e.g.:
> 
> WARN("%p: number of RX queues on device must by a power of 2. Allocating %u
> 	queues, of which %u will be active. Remaining queues will be inactive"...)
> 

You're right, I'll send a v2 with a clearer message.

Regards,
Olivier