From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <vido@cesnet.cz>
Received: from office2.cesnet.cz (office2.cesnet.cz [195.113.144.244])
 by dpdk.org (Postfix) with ESMTP id 543042904
 for <dev@dpdk.org>; Thu, 24 Mar 2016 18:52:30 +0100 (CET)
Received: from [192.168.1.13] (adsl-dyn103.78-99-242.t-com.sk [78.99.242.103])
 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 by office2.cesnet.cz (Postfix) with ESMTPSA id E536DED5DCB;
 Thu, 24 Mar 2016 18:52:29 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cesnet.cz;
 s=office2; t=1458841950;
 bh=P8B18FxotVv5n0akx5EXCZl2Niz4RI+JU635FoMDqoo=;
 h=Subject:To:References:Cc:From:Message-ID:Date:MIME-Version:
 In-Reply-To:Content-Type:Content-Transfer-Encoding;
 b=ipL0FCd4xGwth0oTD83GPlvI+IwwfWy4QHizuwHMTUj/m15NJ9oqpnh+dhYdLVacw
 fDMuijlYC/B2tGfR8tse7CGCUaEbeuB9V12x9nQT8HT7OFkxVrYWorJxvWA8+MCnyi
 xn4zvHn4G60GUyfgzflVXHTSx9g4R/hT3K1/65x4=
To: Stephen Hemminger <stephen@networkplumber.org>
References: <1434702301-4509-1-git-send-email-vido@cesnet.cz>
 <1434702301-4509-2-git-send-email-vido@cesnet.cz>
 <20160321104508.2a318a69@xeon-e3>
Cc: dev@dpdk.org
From: Matej Vido <vido@cesnet.cz>
Message-ID: <56F4295D.3000806@cesnet.cz>
Date: Thu, 24 Mar 2016 18:52:29 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <20160321104508.2a318a69@xeon-e3>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH 1/2] szedata2: new poll mode driver
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 24 Mar 2016 17:52:30 -0000

Dňa 21.03.2016 o 18:45 Stephen Hemminger napísal(a):
> On Fri, 19 Jun 2015 10:25:00 +0200
> Matej Vido <vido@cesnet.cz> wrote:
>
>> +static struct ether_addr eth_addr = {
>> +	.addr_bytes = { 0, 0, 0, 0x1, 0x2, 0x3 }
>> +};
> ...
>
>> static int
>> rte_szedata2_eth_dev_init(struct rte_eth_dev *dev)
>> {
> ..
>> 	/* Allocate space for one mac address */
>> 	data->mac_addrs = rte_zmalloc(data->name, sizeof(struct ether_addr),
>> 			RTE_CACHE_LINE_SIZE);
>> 	if (data->mac_addrs == NULL) {
>> 		RTE_LOG(ERR, PMD, "Could not alloc space for MAC address!\n");
>> 		munmap(dev->pci_dev->mem_resource[PCI_RESOURCE_NUMBER].addr,
>> 			dev->pci_dev->mem_resource[PCI_RESOURCE_NUMBER].len);
>> 		return -EINVAL;
>> 	}
>>
>> 	ether_addr_copy(&eth_addr, data->mac_addrs);
> If your hardware has no permanent MAC address, then please use eth_random_addr()
> to make one on boot, rather than having a bogus static value.
Hi,

I will use it.

Thanks,
Matej