From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rcdn-iport-5.cisco.com (rcdn-iport-5.cisco.com [173.37.86.76]) by dpdk.org (Postfix) with ESMTP id 9AD8B95CA for ; Thu, 31 Mar 2016 19:33:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=919; q=dns/txt; s=iport; t=1459445602; x=1460655202; h=subject:to:references:cc:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=8q6URQ04S9COXyOWLzBAersH3cL5bj47uoNG9JDcwI8=; b=lovVXUDht5/G7SP6dVIPCniM9ttOQ9EouJnJuqc5Jky6i/oTe5K8irHN qNdzjZV0xHLFb/QumoBXjY3gIxP9goy66P+julziNO++DZtIaBH77ed8C Bgvogb2NdT/ua0TXb8aK5nTziR6oHZ9n4slFjvZyu4E8iC2Izr5eD3Lr2 o=; X-IronPort-AV: E=Sophos;i="5.24,423,1454976000"; d="scan'208";a="88748736" Received: from rcdn-core-10.cisco.com ([173.37.93.146]) by rcdn-iport-5.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Mar 2016 17:33:21 +0000 Received: from [171.71.12.193] (dhcp-171-71-12-193.cisco.com [171.71.12.193]) by rcdn-core-10.cisco.com (8.14.5/8.14.5) with ESMTP id u2VHXLX6002131; Thu, 31 Mar 2016 17:33:21 GMT To: Thomas Monjalon , "John Daley (johndale)" References: <1458953090-12764-1-git-send-email-johndale@cisco.com> <5397245.3TK0dfaEoQ@xps13> Cc: "dev@dpdk.org" From: Nelson Escobar Message-ID: <56FD5F61.9010002@cisco.com> Date: Thu, 31 Mar 2016 10:33:21 -0700 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <5397245.3TK0dfaEoQ@xps13> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] bonding: fix bond link detect in non-interrupt mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Mar 2016 17:33:22 -0000 Thomas, Sorry, I should have included the following fixes line: Fixes: a45b288ef21a("bond: support link status polling") Please add it to the commit message when applying if there are no other problems with the patch. Nelson. On 3/31/2016 6:40 AM, Thomas Monjalon wrote: > 2016-03-25 17:44, John Daley: >> From: Nelson Escobar >> >> Stopping then re-starting a bond interface containing slaves that >> used polling for link detection caused the bond to think all slave >> links were down and inactive. >> >> Move the start of the polling for link from slave_add() to >> bond_ethdev_start() and in bond_ethdev_stop() make sure we clear >> the last_link_status of the slaves. >> >> Signed-off-by: Nelson Escobar >> Signed-off-by: John Daley > > A "Fixes:" line would be appreciated to know the origin of the bug. > Thanks >