From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9785FA0543; Tue, 6 Sep 2022 15:02:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7B2D940143; Tue, 6 Sep 2022 15:02:13 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by mails.dpdk.org (Postfix) with ESMTP id DCEC8400D6 for ; Tue, 6 Sep 2022 15:02:11 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZY+coGkqtz0gOGgV1p2ZS1uXEzX7p7zfLpczTQFuSCkf4+g6VHhx+gwssMZ3eE+N3uk0PU95IjHYcEFVi/LN8EnRbnnMqIY7ln6BcyQ+0oahQQ23qfP3mOrwnDnsza1aj78RdkmeW1MCt56CX5SqBRHOMzXnkKrRvO7cc+vv3YU5Q9F+BLeX2/s0yVFDxKpoDAnuro9a3alZUWq+bQBdAvK2C7TYmsmGX6tpg/AEw4MlPEx1naPCSN/OcNhul5hodW6Hhraz1X+oCltlY4pe/+I+fLTD68PzVbINzYsEUfyeVC231Hs+jM9LvMX0p3vbjYNA+Vn8mfXHcv1R96JL6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iH38qK80ICZkQBRJhnOG7/2dCSa5dPoA8BId7zIVWTA=; b=ds31QM+ITumpx1wHxBIe+MSfy0xPsaxyhBXAl3B+OpRrhoQh1/xrWUXYIAuTUr7RFd/We37dntQ3InD5qnBIPU9SYfZmQgu0vO4cc/nFU1F8SPZZqCJnMCxBUYKZtxBfJSCupkGRy9aq/fcLZKAcHbGGJyhVxf4BWMQBdjUnNrFkGC+f592/4doBr4eYmnxv5pwZ6/5xRlx+bnyMT2wxKgw/9AJhaIZtalVsHCtow42o8cfkdpXCqpDJ5GHv2YZAgSSULiK5MCm20eqKs8ipPqzYsXH1wW1EbXmjlAgDn+Pc8sVcZbOIQfcG0UycCN3dMzXKErfLs/bwWBZHQn6fpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=microsoft.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iH38qK80ICZkQBRJhnOG7/2dCSa5dPoA8BId7zIVWTA=; b=LRme9AsrsShbsiK68LMqjikmUjr3JXmJFr0XxlIeqA+0kfiP6S5wXY09tr1PF9bytNVf1FgtoFSrgnn9dzTPDm8byrbIbbIzlKWxGAwN44Yk+Exnn+m7YwhRueN4cH7+Okqz1BCDHDz35VK7tt+2nxN/Dts+2CybUsEAXT+RBkI= Received: from DM6PR01CA0027.prod.exchangelabs.com (2603:10b6:5:296::32) by SN6PR02MB4208.namprd02.prod.outlook.com (2603:10b6:805:39::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10; Tue, 6 Sep 2022 13:01:37 +0000 Received: from DM3NAM02FT060.eop-nam02.prod.protection.outlook.com (2603:10b6:5:296:cafe::6e) by DM6PR01CA0027.outlook.office365.com (2603:10b6:5:296::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.10 via Frontend Transport; Tue, 6 Sep 2022 13:01:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch02.xlnx.xilinx.com; pr=C Received: from xir-pvapexch02.xlnx.xilinx.com (149.199.80.198) by DM3NAM02FT060.mail.protection.outlook.com (10.13.4.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5588.10 via Frontend Transport; Tue, 6 Sep 2022 13:01:37 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch02.xlnx.xilinx.com (172.21.17.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Tue, 6 Sep 2022 14:01:35 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2375.24 via Frontend Transport; Tue, 6 Sep 2022 14:01:35 +0100 Envelope-to: longli@microsoft.com, dev@dpdk.org, sharmaajay@microsoft.com, sthemmin@microsoft.com Received: from [10.71.194.74] (port=60683) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1oVYCt-00055r-9s; Tue, 06 Sep 2022 14:01:35 +0100 Message-ID: <56ad0919-f923-5afd-c099-6321eedde5e3@xilinx.com> Date: Tue, 6 Sep 2022 14:01:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [Patch v7 01/18] net/mana: add basic driver, build environment and doc Content-Language: en-US To: CC: , Ajay Sharma , Stephen Hemminger References: <1662169260-4953-1-git-send-email-longli@linuxonhyperv.com> <1662169260-4953-2-git-send-email-longli@linuxonhyperv.com> From: Ferruh Yigit In-Reply-To: <1662169260-4953-2-git-send-email-longli@linuxonhyperv.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 352cbb13-7c29-4cd1-5b0a-08da9007eed8 X-MS-TrafficTypeDiagnostic: SN6PR02MB4208:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yk/XAW8qLIyIvz3xymrSaHsKSzKFCF89cwCz3fNQv5K8SrYqUkZ50hBtP4BZ+CJaSnviZ3kffBxFzNnwSaHCuvHsreOJTQb3Pf++K/0aV59Qi3lK5FvIdJHa4M4kolsLWGJ6omJ1VxMhuAQVBsf0iNEXXCtS5BWnXgO8lBYOXYxrneEHMwcENewoGkiI00kemuJUR5zBzVu5vawzYzXp1/Iu2QaHvLImo44ABWVVlFCxmI2L+wXECIlh6BKd0Lr0D1GRn5tM2ZnGf9SO3jDrdsajvrtYfGtMom/5I6EthB7bqYr88ygRvz9dZpvM7buuOf2GR5xFBwc477yPuOu16ikys6sC2r/jTxKWTl6TyYHkAIxij7tyoSCZfVIEjky0xONEi3YdEnoe+mOrgKuQv4Kqr8sz8UzknZhYCN/vM3/4VihZQCzxoJHCnjVWZhwYaAoAAVyDFpIj3+tKlVisv/CHR54Vz2HinR28w4BTgCR8uoLNSDogr+/aO1XpM4qp0yj50Tkanc8lkA2w44T+wVaqJ88E6SlWekDUXJzoMKStsbuFGJvAKL8SZ5k9WVjB8TXb//eV+7iW+243i/O4uK0CcYBdYypA6i9/BPALMNssDrKzq9gwcFGyX2ZzxUYeY5NmzhEn6Ww+jDoexx+gG/NZQ52CvYbT1NDolITNP6dbzfmeYMVJZctn5FtAt7m8hS5RGopbmSa0NFPSFKwQcVh49NpTQ1++DbeteoVoo8c/Y+2Iv2y1SAOr7tBsxVoF1jp6QY5k2fToAd6aES61nlQFoIXqAh471zzBp5nXp7yS5OitxWAwnYSaprYzzdaDvsJM7RyWEb/fO6eQ4ZmxJBMYDWylSTm2IXzZOhj5ofs= X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch02.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230016)(4636009)(396003)(376002)(136003)(346002)(39860400002)(36840700001)(40470700004)(46966006)(54906003)(966005)(45080400002)(478600001)(316002)(40480700001)(4326008)(82310400005)(31686004)(70206006)(5660300002)(6916009)(2906002)(8936002)(82740400003)(9786002)(8676002)(44832011)(40460700003)(70586007)(36756003)(7636003)(36860700001)(356005)(31696002)(26005)(53546011)(83380400001)(41300700001)(336012)(2616005)(186003)(47076005)(426003)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Sep 2022 13:01:37.0173 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 352cbb13-7c29-4cd1-5b0a-08da9007eed8 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT060.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR02MB4208 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/3/2022 2:40 AM, longli@linuxonhyperv.com wrote: > > From: Long Li > > MANA is a PCI device. It uses IB verbs to access hardware through the > kernel RDMA layer. This patch introduces build environment and basic > device probe functions. > > Signed-off-by: Long Li > --- > Change log: > v2: > Fix typos. > Make the driver build only on x86-64 and Linux. > Remove unused header files. > Change port definition to uint16_t or uint8_t (for IB). > Use getline() in place of fgets() to read and truncate a line. > v3: > Add meson build check for required functions from RDMA direct verb header file > v4: > Remove extra "\n" in logging code. > Use "r" in place of "rb" in fopen() to read text files. > v7: > Remove RTE_ETH_TX_OFFLOAD_TCP_TSO from offload cap. > Can you please check review comments on v4 [1], they seem still valid in this version. I didn't go through other patches, but can you please double check comments on all v4 patches? [1] https://inbox.dpdk.org/dev/859e95d9-2483-b017-6daa-0852317b4a72@xilinx.com/