From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Wei Hu (Xavier)" <huwei013@chinasoftinc.com>, dev@dpdk.org
Cc: xavier.huwei@huawei.com
Subject: Re: [dpdk-dev] [PATCH v2 7/9] net/hns3: support start and stop Tx or Rx queue
Date: Wed, 30 Sep 2020 23:54:00 +0100 [thread overview]
Message-ID: <56bfe2d0-d832-9ba7-88e3-f7e6959299e6@intel.com> (raw)
In-Reply-To: <e0460b67-1b83-c2b2-a73f-31df34e5d2ca@intel.com>
On 9/30/2020 11:49 PM, Ferruh Yigit wrote:
> On 9/29/2020 1:01 PM, Wei Hu (Xavier) wrote:
>> From: Chengchang Tang <tangchengchang@huawei.com>
>>
>> The new generation hns3 network engine supports independent enabling and
>> disabling of a single Tx/Rx queue. So, it can support the queue start and
>> stop feature. In addition, when different numbers of Tx and Rx queues need
>> to be enabled in some applications, hns3 pmd does not need to create fake
>> queues to enable these scenarios.
>>
>> This patch Add queue start and stop feature for the new generation hns3
>> networking engine. Cancel the creation of fake queue on the new generation
>> network engine. And the previously improperly named queue related function
>> was renamed to improve readability.
>>
>> Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
>> Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
>
> <...>
>
>> @@ -5626,6 +5666,10 @@ static const struct eth_dev_ops hns3_eth_dev_ops = {
>> .tx_queue_setup = hns3_tx_queue_setup,
>> .rx_queue_release = hns3_dev_rx_queue_release,
>> .tx_queue_release = hns3_dev_tx_queue_release,
>> + .rx_queue_start = hns3_dev_rx_queue_start,
>> + .rx_queue_stop = hns3_dev_rx_queue_stop,
>> + .tx_queue_start = hns3_dev_tx_queue_start,
>> + .tx_queue_stop = hns3_dev_tx_queue_stop,
>> .rx_queue_intr_enable = hns3_dev_rx_queue_intr_enable,
>> .rx_queue_intr_disable = hns3_dev_rx_queue_intr_disable,
>> .rxq_info_get = hns3_rxq_info_get,
>
>
> Can you please update feature files ('hns3.ini' & 'hns3_vf.ini') to announce
> "Queue start/stop" feature?
>
This looks like only comment, I will add them while merging, please double check
after merge.
next prev parent reply other threads:[~2020-09-30 22:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 11:09 [dpdk-dev] [PATCH 0/9] updates and fixes for hns3 PMD driver Wei Hu (Xavier)
2020-09-29 11:09 ` [dpdk-dev] [PATCH 1/9] net/hns3: expand the number of queues for one TC up to 512 Wei Hu (Xavier)
2020-09-29 11:09 ` [dpdk-dev] [PATCH 2/9] net/hns3: maximize the queue number Wei Hu (Xavier)
2020-09-29 11:09 ` [dpdk-dev] [PATCH 3/9] net/hns3: fix error type when validating RSS flow action Wei Hu (Xavier)
2020-09-29 11:09 ` [dpdk-dev] [PATCH 4/9] net/hns3: set suitable type when initial flow error struct Wei Hu (Xavier)
2020-09-29 11:09 ` [dpdk-dev] [PATCH 5/9] net/hns3: offload calculating the shapping para to firmware Wei Hu (Xavier)
2020-09-29 11:09 ` [dpdk-dev] [PATCH 6/9] net/hns3: set max scheduling rate based on actual board Wei Hu (Xavier)
2020-09-29 11:09 ` [dpdk-dev] [PATCH 7/9] net/hns3: support start and stop Tx or Rx queue Wei Hu (Xavier)
2020-09-29 11:09 ` [dpdk-dev] [PATCH 8/9] net/hns3: check return value when reading PCI config space Wei Hu (Xavier)
2020-09-29 11:09 ` [dpdk-dev] [PATCH 9/9] net/hns3: remove redundant return value assignments Wei Hu (Xavier)
2020-09-29 12:01 ` [dpdk-dev] [PATCH v2 0/9] updates and fixes for hns3 PMD driver Wei Hu (Xavier)
2020-09-29 12:01 ` [dpdk-dev] [PATCH v2 1/9] net/hns3: expand the number of queues for one TC up to 512 Wei Hu (Xavier)
2020-09-29 12:01 ` [dpdk-dev] [PATCH v2 2/9] net/hns3: maximize the queue number Wei Hu (Xavier)
2020-09-29 12:01 ` [dpdk-dev] [PATCH v2 3/9] net/hns3: fix error type when validating RSS flow action Wei Hu (Xavier)
2020-09-29 12:01 ` [dpdk-dev] [PATCH v2 4/9] net/hns3: set suitable type when initial flow error struct Wei Hu (Xavier)
2020-09-29 12:01 ` [dpdk-dev] [PATCH v2 5/9] net/hns3: offload calculating the shapping para to firmware Wei Hu (Xavier)
2020-09-29 12:01 ` [dpdk-dev] [PATCH v2 6/9] net/hns3: set max scheduling rate based on actual board Wei Hu (Xavier)
2020-09-29 12:01 ` [dpdk-dev] [PATCH v2 7/9] net/hns3: support start and stop Tx or Rx queue Wei Hu (Xavier)
2020-09-30 22:49 ` Ferruh Yigit
2020-09-30 22:54 ` Ferruh Yigit [this message]
2020-09-29 12:01 ` [dpdk-dev] [PATCH v2 8/9] net/hns3: check return value when reading PCI config space Wei Hu (Xavier)
2020-09-29 12:01 ` [dpdk-dev] [PATCH v2 9/9] net/hns3: remove redundant return value assignments Wei Hu (Xavier)
2020-09-30 22:59 ` [dpdk-dev] [PATCH v2 0/9] updates and fixes for hns3 PMD driver Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56bfe2d0-d832-9ba7-88e3-f7e6959299e6@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=huwei013@chinasoftinc.com \
--cc=xavier.huwei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).