From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DDC4DA04B5; Thu, 1 Oct 2020 00:54:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 317581D5A8; Thu, 1 Oct 2020 00:54:08 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 5F9641D57A for ; Thu, 1 Oct 2020 00:54:06 +0200 (CEST) IronPort-SDR: KI20Z+f5I+ewoUlLB0V+TM5CY6WBOopLjH1O+GvtL9QIm4CpewxznLgDxK72IVM3WsoCXVKxkJ RQ3h+G0j/XXA== X-IronPort-AV: E=McAfee;i="6000,8403,9760"; a="247288628" X-IronPort-AV: E=Sophos;i="5.77,322,1596524400"; d="scan'208";a="247288628" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2020 15:54:03 -0700 IronPort-SDR: zOTKxNHWI2eASbzN3yRFpKLs2ETEmKKFmtZPB9qMUFeUZ2q3LLKe2Sp0QLzb41chzCGjpXsX+w Xc56t48mRAzQ== X-IronPort-AV: E=Sophos;i="5.77,322,1596524400"; d="scan'208";a="312761563" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.229.39]) ([10.213.229.39]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2020 15:54:01 -0700 From: Ferruh Yigit To: "Wei Hu (Xavier)" , dev@dpdk.org Cc: xavier.huwei@huawei.com References: <20200929110945.70761-1-huwei013@chinasoftinc.com> <20200929120117.50394-1-huwei013@chinasoftinc.com> <20200929120117.50394-8-huwei013@chinasoftinc.com> Message-ID: <56bfe2d0-d832-9ba7-88e3-f7e6959299e6@intel.com> Date: Wed, 30 Sep 2020 23:54:00 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 7/9] net/hns3: support start and stop Tx or Rx queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/30/2020 11:49 PM, Ferruh Yigit wrote: > On 9/29/2020 1:01 PM, Wei Hu (Xavier) wrote: >> From: Chengchang Tang >> >> The new generation hns3 network engine supports independent enabling and >> disabling of a single Tx/Rx queue. So, it can support the queue start and >> stop feature. In addition, when different numbers of Tx and Rx queues need >> to be enabled in some applications, hns3 pmd does not need to create fake >> queues to enable these scenarios. >> >> This patch Add queue start and stop feature for the new generation hns3 >> networking engine. Cancel the creation of fake queue on the new generation >> network engine. And the previously improperly named queue related function >> was renamed to improve readability. >> >> Signed-off-by: Chengchang Tang >> Signed-off-by: Wei Hu (Xavier) > > <...> > >> @@ -5626,6 +5666,10 @@ static const struct eth_dev_ops hns3_eth_dev_ops = { >>       .tx_queue_setup         = hns3_tx_queue_setup, >>       .rx_queue_release       = hns3_dev_rx_queue_release, >>       .tx_queue_release       = hns3_dev_tx_queue_release, >> +    .rx_queue_start         = hns3_dev_rx_queue_start, >> +    .rx_queue_stop          = hns3_dev_rx_queue_stop, >> +    .tx_queue_start         = hns3_dev_tx_queue_start, >> +    .tx_queue_stop          = hns3_dev_tx_queue_stop, >>       .rx_queue_intr_enable   = hns3_dev_rx_queue_intr_enable, >>       .rx_queue_intr_disable  = hns3_dev_rx_queue_intr_disable, >>       .rxq_info_get           = hns3_rxq_info_get, > > > Can you please update feature files ('hns3.ini' & 'hns3_vf.ini') to announce > "Queue start/stop" feature? > This looks like only comment, I will add them while merging, please double check after merge.