From: Tom Barbette <barbette@kth.se>
To: Andrew Rybchenko <arybchenko@solarflare.com>, dev@dpdk.org
Cc: orika@mellanox.com, beilei.xing@intel.com, qi.z.zhang@intel.com
Subject: Re: [dpdk-dev] rte_flow: Different devices have different field indianess?
Date: Fri, 27 Mar 2020 15:51:23 +0100 [thread overview]
Message-ID: <56e1f5fc-e159-6050-0f8e-4ded401db6bb@kth.se> (raw)
In-Reply-To: <fe15b4b2-f5e7-2b9f-1705-98f8a1564815@solarflare.com>
Le 27/03/2020 à 15:44, Andrew Rybchenko a écrit :
> On 3/27/20 5:29 PM, Tom Barbette wrote:
>> Hi all,
>>
>> It seems rte_flow_item_eth takes its ethertype in host byte order with
>> i40e, but in network byte order with mlx5.
>
> If so, it is definitely bug in i40e, since struct rte_flow_item_eth
> defines type as rte_be16_t type.
Indeed, with testpmd I would expect the first one to be the one that works:
testpmd> flow create 0 ingress pattern eth type is 0x0800 / end actions
mark id 5 / end
port_flow_complain(): Caught PMD error type 13 (specific pattern item):
cause: 0x227fd75540, Unsupported ether_type.: Invalid argument
testpmd> flow create 0 ingress pattern eth type is 0x0008 / end actions
mark id 5 / end
Flow rule #0 created
>
>> Wouldn't it be nice to unify that? Else is there a way to know in which
>> byte order the spec should be given? I guess that expands to all fields,
>> but I only compared the ethertype field.
>>
>> Thanks,
>>
>> Tom
>
next prev parent reply other threads:[~2020-03-27 14:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 14:29 Tom Barbette
2020-03-27 14:44 ` Andrew Rybchenko
2020-03-27 14:51 ` Tom Barbette [this message]
2020-03-30 0:48 ` Xing, Beilei
2020-03-28 20:49 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56e1f5fc-e159-6050-0f8e-4ded401db6bb@kth.se \
--to=barbette@kth.se \
--cc=arybchenko@solarflare.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=orika@mellanox.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).