From: Olivier Matz <olivier.matz@6wind.com>
To: "Azarewicz, PiotrX T" <piotrx.t.azarewicz@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1 1/1] cmdline: add any multi string mode to token string
Date: Mon, 4 Apr 2016 17:57:33 +0200 [thread overview]
Message-ID: <57028EED.9020008@6wind.com> (raw)
In-Reply-To: <4837007523CC9A4B9414D20C13DE6E6413687FDB@IRSMSX102.ger.corp.intel.com>
Hi Piotr,
On 04/04/2016 04:11 PM, Azarewicz, PiotrX T wrote:
>> Using token_len + 1 as the buffer size in the snprintf looks a bit dangerous, as
>> it won't protect from overflows.
>>
>> See the following example:
> <snip>
> > That's why snprintf() should still use STR_TOKEN_SIZE.
>>
> Okay, I see it.
> But this is a problem that we may need longer string than STR_TOKEN_SIZE in multi token case.
> So what you think about adding new typedef cmdline_multi_string_t for this case?
> For example:
> #define STR_MULTI_TOKEN_SIZE 1024
> typedef char cmdline_multi_string_t[STR_MULTI_TOKEN_SIZE];
It should do the job, indeed.
By the way, it would be nice to have an example of use.
Regards,
Olivier
next prev parent reply other threads:[~2016-04-04 15:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 11:36 Piotr Azarewicz
2016-04-04 8:00 ` Olivier Matz
2016-04-04 14:11 ` Azarewicz, PiotrX T
2016-04-04 15:57 ` Olivier Matz [this message]
2016-04-05 6:58 ` Azarewicz, PiotrX T
2016-04-05 8:47 ` [dpdk-dev] [PATCH v2 " Piotr Azarewicz
2016-04-05 11:21 ` Olivier Matz
2016-04-05 15:39 ` Thomas Monjalon
2016-04-15 14:41 ` Wiles, Keith
2016-04-28 14:52 ` Olivier MATZ
2016-04-29 7:14 ` Azarewicz, PiotrX T
2016-04-29 14:29 ` [dpdk-dev] [PATCH v3 " Piotr Azarewicz
2016-05-02 13:32 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57028EED.9020008@6wind.com \
--to=olivier.matz@6wind.com \
--cc=dev@dpdk.org \
--cc=piotrx.t.azarewicz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).