From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C834741CDD; Sun, 19 Feb 2023 12:09:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 241D042D10; Sun, 19 Feb 2023 12:09:00 +0100 (CET) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id E426940698; Sun, 19 Feb 2023 12:08:57 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 7EA145C012B; Sun, 19 Feb 2023 06:08:57 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 19 Feb 2023 06:08:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1676804937; x= 1676891337; bh=NMW2yxt3K5XNWl5FaObup5FQOsCMffv0OdKjeSSaneY=; b=W rdgsASMHr3U1F4zg3K6Odq3jKh8SlaGS1JIgwR+7qwcqVyOtK+gDoqYm2ayb6hKT 8QSzK3HvrpubB6jNo6xlnFWmB6ey99jphHyXXiYtXAJNNEv6wKARsyhIKO45IQNh +V2ypuxKNGE1FZNTI6bSv3ur94kv1Oc7lKRoRP6oYImgXe8lhPL8E6c81l90b1OK qajVgWkafpUuhjywIcS1Lmlh1oiLHVqit3h8D1dlWAA7PbAVZal9Hy2h9DqkwMno 9fOYAyBEdb5IdGLcNwCCb/7E/nNt17VuiVvFRPG3QKEGYwoM6cAgok9H6LQhnyqM xKkL3ORdwtbwbkANXv2bQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1676804937; x= 1676891337; bh=NMW2yxt3K5XNWl5FaObup5FQOsCMffv0OdKjeSSaneY=; b=B SkHUiWdQT+2zleDI2K2kdfJAAAM2Dg9e9A9pLNnbuoGiy4m03NtNfDbJkZzGmfTR 4Ju2W0XEF4d0Ii1+YDffxxe0Pn+bK+mScO63OVLD17HObPHlzl97TwijBS65qQNJ FwRzz1ie/I7owak6Spj/2FKnEXgYKijMmjP/s5Ptau9hq5RgwzjxyMeQYREs3M6h 3Muc1x13Ya4N+YriL1bWk6a/j5zUvGf7cVTK+kKmikWG7V1tKKR2RterOsGGEXGm y8ATU1bBF8NyemoDdRFXidZIB43sKWC7wk9uifReQ3spX6xOykYJDsA4jlM911hy 4iZQiAryp8RmTtDeOhxdw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudejfedgvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 19 Feb 2023 06:08:55 -0500 (EST) From: Thomas Monjalon To: "mb@smartsharesystems.com" , "Richardson, Bruce" , "Lu, Wenzhuo" , dev@dpdk.org, "Wu, Wenjun1" , stable@dpdk.org Cc: "stable@dpdk.org" , "Zhang, Qi Z" , david.marchand@redhat.com, bruce.richardson@intel.com, Shijith Thotton Subject: Re: [PATCH v2] net: not build PMD AVX library when no IOVA as PA Date: Sun, 19 Feb 2023 12:08:54 +0100 Message-ID: <5705342.1B3tZ46Xf9@thomas> In-Reply-To: <3023187.ktpJ11cQ8Q@thomas> References: <20221212121711.857866-1-qi.z.zhang@intel.com> <3023187.ktpJ11cQ8Q@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 19/02/2023 11:04, Thomas Monjalon: > 29/01/2023 13:35, Zhang, Qi Z: > > From: Zhang, Qi Z > > > > > > PMD not announce pmd_supports_disable_iova_as_pa will not be build > > > when RTE_IOVA_AS_PA is not defined, but some AVX library for vector path > > > is not skipped by the build system which cause compile error. > > > > > > The patch modify i40e, iavf, ice's meson file to skip AVX library build when > > > RTE_IOVA_AS_PA is not defined. > > > > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Qi Zhang > > > > Move this for next-net review. > > > > Acked-by: Qi Zhang > > You ack your own patch? > > > Applied to dpdk-next-net-intel. > > Sorry I don't pull this one, as I think there is a better fix: > we should not handle this option in each driver. > Instead the file drivers/meson.build must be fixed. No sorry, it cannot be handled in drivers/meson.build. So I suggest disabling the whole driver: +if not get_option('enable_iova_as_pa') + subdir_done() +endif Note: no need to disable ice, as it is enabled in another commit.