From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f53.google.com (mail-pa0-f53.google.com [209.85.220.53]) by dpdk.org (Postfix) with ESMTP id 9876528F2 for ; Fri, 8 Apr 2016 09:03:14 +0200 (CEST) Received: by mail-pa0-f53.google.com with SMTP id td3so69807926pab.2 for ; Fri, 08 Apr 2016 00:03:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=igel-co-jp.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=hWH/HTwbs6jhSsMD0HIsYtTZnCGj2XaFpjfvx+z/GdQ=; b=LUJmEcORcg6rPsKYzCW+tRwDybCTjvpKIMi8BZsgSAUX6QmCJWy2AOrnUvr2g7puJk VCNHXAtUXcahic5qtS6afB4j6REw9vTd+RDjQ+VAaNYv7E1Mip4dmO24L5SAOhAgxRY3 gN1A+/FuD0INM3I+BdEZp29aG/y1K3Agj9QP5qwS9gGCf1iejVZTpUozTJ4tcpT+3d6+ 8MDxz7ECjNiBXIdgi3v5elselVfTzL0rFvug0cpHZuSmIZkn6K1cBmQfB1aJ6uttdTHH +slPZ1HYDCeVxcLM2HrEOGUy6VXNbGoidHWqWmgepbSIrWCkUhaS9r57dkfIWCBPxgWJ kULg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=hWH/HTwbs6jhSsMD0HIsYtTZnCGj2XaFpjfvx+z/GdQ=; b=e62NHBy/RL8mIodu4/YI92qM923jtSQE9UON459fF6Vkdgxp6NEOt8mxIky6CFZxfp FjbV6hle/gmEA2aLZX+bmnGnAt9NKfv8L2WjdxKR9w3ufbymhv8BFVqrZczJACEJLLG1 yO3Ug4H33F9Iw2Mb83YJUSTWZ4K8TR032pORW9AHmZR0WWSertbO1F7MMl8+dCEDbc9z ej3IenkGrdX0FAdPExUmr66nHBM1TnHabvOmAXNx1k58SMqPkunyHnhAy5Q9uF1bIP+z xZys7EFeE9laHHn91XIUz47zHtX0sYKo4gZV24zn+ALC+Ta0rRAeYZ4Y5oSftP7NI29O Oj9A== X-Gm-Message-State: AD7BkJJOhpB1xO2LZt3wCb1lhNcF0jPaAHiqRQdOB9Z2UBSiTPcOqKxlFwRS11GyNFZIBg== X-Received: by 10.66.66.198 with SMTP id h6mr10391186pat.112.1460098993862; Fri, 08 Apr 2016 00:03:13 -0700 (PDT) Received: from [10.16.129.101] (napt.igel.co.jp. [219.106.231.132]) by smtp.googlemail.com with ESMTPSA id d19sm16392673pfj.92.2016.04.08.00.03.12 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 08 Apr 2016 00:03:13 -0700 (PDT) To: Yuanhan Liu References: <1459988946-5956-1-git-send-email-rich.lane@bigswitch.com> <20160407154235.GD3080@yliu-dev.sh.intel.com> <6607494.IC538dk6LI@xps13> <57070D3D.2070700@igel.co.jp> <20160408061458.GF3080@yliu-dev.sh.intel.com> Cc: Thomas Monjalon , Rich Lane , dev@dpdk.org From: Tetsuya Mukawa Message-ID: <570757B0.9080300@igel.co.jp> Date: Fri, 8 Apr 2016 16:03:12 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <20160408061458.GF3080@yliu-dev.sh.intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] vhost: call rte_vhost_enable_guest_notification only on enabled queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Apr 2016 07:03:15 -0000 On 2016/04/08 15:14, Yuanhan Liu wrote: > On Fri, Apr 08, 2016 at 10:45:33AM +0900, Tetsuya Mukawa wrote: >> On 2016/04/08 2:20, Thomas Monjalon wrote: >>>>> If the vhost PMD were configured with more queues than the guest, the old >>>>> code would segfault in rte_vhost_enable_guest_notification due to a NULL >>>>> virtqueue pointer. >>>>> >>>>> Fixes: ee584e9710b9 ("vhost: add driver on top of the library") >>>>> Signed-off-by: Rich Lane >>>> Acked-by: Yuanhan Liu >>> Applied, thanks >> Hi Rich and Yuanhan, >> >> I am sorry for late reply. I was out of office yesterday. > Tetsuya, no worry! Man takes leaves, and isn't the reason we have 2 or > more maintainers on some blocks? :) > > --yliu Yeah, thanks! Tetsuya