From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <markus.theil@tu-ilmenau.de>
Received: from smail.rz.tu-ilmenau.de (smail.rz.tu-ilmenau.de [141.24.186.67])
 by dpdk.org (Postfix) with ESMTP id 4B4777CBD
 for <dev@dpdk.org>; Mon,  4 Sep 2017 17:16:26 +0200 (CEST)
Received: from [141.24.212.108] (thunderstorm.prakinf.tu-ilmenau.de
 [141.24.212.108])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by smail.rz.tu-ilmenau.de (Postfix) with ESMTPSA id EC81358005E;
 Mon,  4 Sep 2017 17:16:24 +0200 (CEST)
To: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org
Cc: stephen@networkplumber.org
References: <1504174949-25656-3-git-send-email-markus.theil@tu-ilmenau.de>
 <1504216020-16067-1-git-send-email-markus.theil@tu-ilmenau.de>
 <1504216020-16067-4-git-send-email-markus.theil@tu-ilmenau.de>
 <7f2b5fab-4e5d-aa21-48f8-54675949dc94@intel.com>
From: Markus Theil <markus.theil@tu-ilmenau.de>
Organization: TU Ilmenau
Message-ID: <5713124c-cc52-016a-9e74-1c22220b856b@tu-ilmenau.de>
Date: Mon, 4 Sep 2017 17:16:24 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <7f2b5fab-4e5d-aa21-48f8-54675949dc94@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Content-Language: en-US
Subject: Re: [dpdk-dev] [PATCH v5 4/5] igb_uio: use msi mask functions from
 kernel, little corrections
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Sep 2017 15:16:26 -0000

On 04.09.2017 14:43, Ferruh Yigit wrote:
> On 8/31/2017 10:46 PM, Markus Theil wrote:
>> This patch substitutes the custom MSI/MSI-X mask code and uses
>> already existing kernel APIs. Feedback/small corrections to the previo=
us
>> patch of this series are also incorporated.
>>
>> Signed-off-by: Markus Theil <markus.theil@tu-ilmenau.de>
> <...>
>
>> +	if (udev->mode =3D=3D RTE_INTR_MODE_MSIX || udev->mode =3D=3D RTE_IN=
TR_MODE_MSI) {
>> +#ifdef HAVE_PCI_MSI_MASK_IRQ
>> +		if (irq_state =3D=3D 1)
>> +			pci_msi_unmask_irq(irq);
>> +		else
>> +			pci_msi_mask_irq(irq);
> It is an option to keep using mask_msi_irq() without #ifdef, it seems i=
n
> newer version of the kernel mask_msi_irq() is already wrapper to the
> pci_msi_mask_irq().
>
> Although this may make the code simpler, it can break it if
> mask_msi_irq() wrapper removed.
>
> I would go with using mask_msi_irq() directly, but no strong opinion...=

>
> <...>
I don't know what the comment "Conversion helpers. Should be removed
after merging" in msi.h really means. If the functions following the
comment are deleted in one of the next versions, I would not change
these lines. Otherwise I second your comment.