From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 793C1A10D6 for ; Fri, 23 Aug 2019 12:01:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 425C61BFB2; Fri, 23 Aug 2019 12:01:24 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id D02E21BFA4; Fri, 23 Aug 2019 12:01:22 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2F8DCC03D478; Fri, 23 Aug 2019 10:01:22 +0000 (UTC) Received: from [10.36.116.48] (ovpn-116-48.ams2.redhat.com [10.36.116.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id 817BE10016E9; Fri, 23 Aug 2019 10:01:20 +0000 (UTC) To: Flavia Musatescu , dev@dpdk.org Cc: kevin.laatz@intel.com, stable@dpdk.org, Reshma Pattan , ciara.power@intel.com, bruce.richardson@intel.com References: <1562077208-15355-1-git-send-email-flavia.musatescu@intel.com> From: Kevin Traynor Message-ID: <571738bd-fbe5-42e5-5abc-cfec4f0aa71b@redhat.com> Date: Fri, 23 Aug 2019 11:01:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <1562077208-15355-1-git-send-email-flavia.musatescu@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Fri, 23 Aug 2019 10:01:22 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] telemetry: fix build warnings seen when using gcc 9 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 02/07/2019 15:20, Flavia Musatescu wrote: > Suppress the unaligned packed member address warnings by extending > the telemetry library build flags with -Wno-address-of-packed-member > option, through the WERROR_FLAGS makefile variable. > > With this change additional warnings are turned on to be treated as errors, > which causes the following build issues to be seen: > - no previous prototype [-Werror=missing-prototypes] > - initialization discards ‘const’ qualifier from pointer target type > [-Werror=discarded-qualifiers] > - old-style function definition [-Werror=old-style-definition] > - variable may be used before its value is set (when using icc compiler). > > Fixes: 0fe3a37924d4 ("telemetry: format json response when sending stats") > Fixes: ee5ff0d3297e ("telemetry: add client feature and sockets") > Fixes: 8877ac688b52 ("telemetry: introduce infrastructure") > Fixes: 1b756087db93 ("telemetry: add parser for client socket messages") > Fixes: fff6df7bf58e ("telemetry: fix using ports of different types") > Fixes: 4080e46c8078 ("telemetry: support global metrics") > Cc: stable@dpdk.org > > Signed-off-by: Reshma Pattan > Signed-off-by: Flavia Musatescu Hi Flavio, in the 18.11. stable branch, I had "fixed" the gcc9 warnings in telemetry with 2ae7bca9594d ("mk: disable packed member pointer warning for telemetry") This patch in 18.11 branch is causing the following build error: /root/lts/dpdk-18.11/lib/librte_telemetry/rte_telemetry.c:1822:13: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers] .opt_str = "--telemetry", ^~~~~~~~~~~~~ I'm inclined to just keep the existing existing patch in stable and not apply this one. Or if you want to do a backport for 18.11 branch that is ok too. WDYT?