From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0B3C1A32A2 for <public@inbox.dpdk.org>; Thu, 24 Oct 2019 12:18:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 46E611C1A8; Thu, 24 Oct 2019 12:18:34 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 87E7B1C1A5 for <dev@dpdk.org>; Thu, 24 Oct 2019 12:18:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571912312; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=kYdQR0FRz3tgYYzowes9IaxnbHpOgVuCunPZneYpaGc=; b=GBo87hVWohC3WUbGZG/RnCJkUE1l76hGs7JlLnDCw+jhaTZ5b+hE6sb/7uFjWOcfd4u6/+ DsZQzkFa5HNXMV0k41xES8kB3gTznTDWik1TVm65wKkxc/4/RRF+dIvIl6IBU74iIKMRLo KbFFyKob9P8i/jxHUzOIePVkBZ9fCqI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-154-drAKPriMOR2cr0QEGS46JQ-1; Thu, 24 Oct 2019 06:18:28 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 29489800D4C; Thu, 24 Oct 2019 10:18:27 +0000 (UTC) Received: from [10.36.112.34] (ovpn-112-34.ams2.redhat.com [10.36.112.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C7880600C4; Thu, 24 Oct 2019 10:18:24 +0000 (UTC) To: Marvin Liu <yong.liu@intel.com>, tiwei.bie@intel.com, zhihong.wang@intel.com, stephen@networkplumber.org, gavin.hu@arm.com Cc: dev@dpdk.org References: <20191021220813.55236-1-yong.liu@intel.com> <20191024160832.14543-1-yong.liu@intel.com> From: Maxime Coquelin <maxime.coquelin@redhat.com> Autocrypt: addr=maxime.coquelin@redhat.com; keydata= mQINBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABtCxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPokCOAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASq5Ag0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAGJ Ah8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= Message-ID: <5720627e-b8e6-7cbc-db9d-96aef2ba3409@redhat.com> Date: Thu, 24 Oct 2019 12:18:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 MIME-Version: 1.0 In-Reply-To: <20191024160832.14543-1-yong.liu@intel.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: drAKPriMOR2cr0QEGS46JQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v9 00/13] vhost packed ring performance optimization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On 10/24/19 6:08 PM, Marvin Liu wrote: > Packed ring has more compact ring format and thus can significantly > reduce the number of cache miss. It can lead to better performance. > This has been approved in virtio user driver, on normal E5 Xeon cpu > single core performance can raise 12%. >=20 > http://mails.dpdk.org/archives/dev/2018-April/095470.html >=20 > However vhost performance with packed ring performance was decreased. > Through analysis, mostly extra cost was from the calculating of each > descriptor flag which depended on ring wrap counter. Moreover, both > frontend and backend need to write same descriptors which will cause > cache contention. Especially when doing vhost enqueue function, virtio > refill packed ring function may write same cache line when vhost doing > enqueue function. This kind of extra cache cost will reduce the benefit > of reducing cache misses.=20 >=20 > For optimizing vhost packed ring performance, vhost enqueue and dequeue > function will be split into fast and normal path. >=20 > Several methods will be taken in fast path: > Handle descriptors in one cache line by batch. > Split loop function into more pieces and unroll them. > Prerequisite check that whether I/O space can copy directly into mbuf > space and vice versa.=20 > Prerequisite check that whether descriptor mapping is successful. > Distinguish vhost used ring update function by enqueue and dequeue > function. > Buffer dequeue used descriptors as many as possible. > Update enqueue used descriptors by cache line. >=20 > After all these methods done, single core vhost PvP performance with 64B > packet on Xeon 8180 can boost 35%. >=20 > v9: > - Fix clang build error >=20 > v8: > - Allocate mbuf by virtio_dev_pktmbuf_alloc >=20 > v7: > - Rebase code > - Rename unroll macro and definitions > - Calculate flags when doing single dequeue >=20 > v6: > - Fix dequeue zcopy result check >=20 > v5: > - Remove disable sw prefetch as performance impact is small > - Change unroll pragma macro format > - Rename shadow counter elements names > - Clean dequeue update check condition > - Add inline functions replace of duplicated code > - Unify code style >=20 > v4: > - Support meson build > - Remove memory region cache for no clear performance gain and ABI break > - Not assume ring size is power of two >=20 > v3: > - Check available index overflow > - Remove dequeue remained descs number check > - Remove changes in split ring datapath > - Call memory write barriers once when updating used flags > - Rename some functions and macros > - Code style optimization >=20 > v2: > - Utilize compiler's pragma to unroll loop, distinguish clang/icc/gcc > - Buffered dequeue used desc number changed to (RING_SZ - PKT_BURST) > - Optimize dequeue used ring update when in_order negotiated >=20 >=20 > Marvin Liu (13): > vhost: add packed ring indexes increasing function > vhost: add packed ring single enqueue > vhost: try to unroll for each loop > vhost: add packed ring batch enqueue > vhost: add packed ring single dequeue > vhost: add packed ring batch dequeue > vhost: flush enqueue updates by cacheline > vhost: flush batched enqueue descs directly > vhost: buffer packed ring dequeue updates > vhost: optimize packed ring enqueue > vhost: add packed ring zcopy batch and single dequeue > vhost: optimize packed ring dequeue > vhost: optimize packed ring dequeue when in-order >=20 > lib/librte_vhost/Makefile | 18 + > lib/librte_vhost/meson.build | 7 + > lib/librte_vhost/vhost.h | 57 ++ > lib/librte_vhost/virtio_net.c | 948 +++++++++++++++++++++++++++------- > 4 files changed, 837 insertions(+), 193 deletions(-) >=20 Applied to dpdk-next-virtio/master. Thanks, Maxime