From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from na01-bn1-obe.outbound.protection.outlook.com (mail-bn1bon0099.outbound.protection.outlook.com [157.56.111.99]) by dpdk.org (Postfix) with ESMTP id E62162B83 for ; Thu, 28 Apr 2016 15:19:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-caviumnetworks-com; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=oSotXLpunw2J/TplMLXmEoisrGOWZsOl4ahgMB6Zb8k=; b=2HzcBJ+zm+53gCFdfNxDbGiopMYiioXBjldh0CzNQnGz3E/vWIS+1sNnP6qqwnVnGfbRNOpje9Qy22AtaZ/D3fJiNoaKefj/O4VdKWaGvq8aGnWaQKgjrPDtqi4GRVxJU+/SJZxXTHteVyl6sPROMfSTXlKWZ4aA8/qRZF3TBpk= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=caviumnetworks.com; Received: from [10.0.2.115] (80.82.22.190) by SN2PR0701MB1037.namprd07.prod.outlook.com (10.160.58.144) with Microsoft SMTP Server (TLS) id 15.1.466.19; Thu, 28 Apr 2016 13:19:20 +0000 To: "De Lara Guarch, Pablo" , "dev@dpdk.org" References: <1461319098-22632-1-git-send-email-maciej.czekaj@caviumnetworks.com> <1461336680-7581-1-git-send-email-maciej.czekaj@caviumnetworks.com> <5721FD7F.8040505@caviumnetworks.com> CC: "Mcnamara, John" From: Maciej Czekaj Message-ID: <57220DCC.6010507@caviumnetworks.com> Date: Thu, 28 Apr 2016 15:19:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [80.82.22.190] X-ClientProxiedBy: AM2PR07CA0024.eurprd07.prod.outlook.com (10.163.24.162) To SN2PR0701MB1037.namprd07.prod.outlook.com (10.160.58.144) X-MS-Office365-Filtering-Correlation-Id: c79333a2-ea7a-485e-73a8-08d36f67b60a X-Microsoft-Exchange-Diagnostics: 1; SN2PR0701MB1037; 2:0Cn3ujIV0HcZvhntmUgi936Y/vFlVrxkTnDGwH+qWGzTtDZFBp3pkUyv1yzbfKgbSDxWRa+XTeRn4wyUgvsfLv8L4gbQsHl3iZKbrufDnUZelp8Rmw9KTnRPZ8yFJYJOt2FH4FgYg7Zr3r0Rd672QOEopf8UdsrSfQqLr1exLZYwKzITAkclqfmLTmZMla2G; 3:HTf3m4VaUUHCFhsiiaoUHJW9nZxIaRB0RQ8fYNnJcUnc8agXw0CFWLcdBvq8dvtTvOpL31JOzv7b4PO73zNXC65eXTGwwSFsF32nZt1Lqy1w/d9sJRVAcV8FWJlb4Bnr X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN2PR0701MB1037; X-Microsoft-Exchange-Diagnostics: 1; SN2PR0701MB1037; 25:6ZZ6euFTeJn0IAT7wnVOVNLayUJ7tOlCGjoPliD5iXUMrtUMIxc9CKhySSg5hTfcgU39LazNXD0LNVX/xx4pn0fciifbu1UzYY7zImHH7g1kn9Oxc4hzOhfjlfkBJdB2WyX+ZWgJDr9Kuzn9V/DENRrESKIKqOuNDRardzh3zjNcgLJQ2VKkrMpnm8tptSpSNVO7cep0c3AlylD/I/YHZWwHYYUlrpUxuYDYyxaVx1X0i+PYXEa2ie5/fDIiXkPmi8cMl9fbq4bW/9gUNDw4/n77BB/qhOfREUYWVdtbDSiWnusyGqjKCiriWbeAQdDhQyF2kgQ0Zj6enelQwq7KP7Us3gp9soQvhMeWkeHSPMwHohb51BqsdwuHqJULuSUd8/s4mGStAg0rSwYOzteYr1SiFWHI6WCv+N7s+8+iPPeq0YrrgzJ2gLT079RADWsNiEMJ/lU+OpgyVG2uA1vceKNhxh6wpUyRDECJyUGN9HHw2/gQjPUksmEEYsqMtfz3ooINnKkw0sa7rXjUypz+9mkB6TLXzOVbx79subxTqgrlwNi/OSoD2Z6xbN46mNUaiKVFXwyCqpeoAOy0EYWz4yZh9u9Vzdw7y3r92jFqAYbSPPJZwJIn+Ynxzl3CynGcQrAJy+nZwrkY24Dc6j/GpX3sejtsuOfEnBcayQVjKLk= X-Microsoft-Exchange-Diagnostics: 1; SN2PR0701MB1037; 20:gZPjd15vD6fUFIL5L73Bx8CxxL3JmgPldhWxc1oVBJloAl+XNQArEF1agT2omQH60RjhNc1KY8fLazVD6BBUn2CMREQXRZTVPMQJpRt5RUhVnhC/W/sGFG9STPdKh4z/5NvrVXwi87JYlSYyroaShGj3r8dHceqLTLUHJpLk1tVA/XeJjVOKKTf/P9fpqfLMhzIC20qPNVWITLfrZn4b/5FRpWQE1NsHAJnbD6ZUYdCxXcZr5jFUTAl4pFkCtsqsjI8rpU4V6OkVr9vr2Yqt1VpyM+GcCg7p2YrZNKallz8U/FgswzymdHMldHYRCUEv6uegGALerKUQpo2sgNZn38nNYevUfx1DzDAuCItEPFAOnidx2e6BHPTMvlnrC4Pq52cFYklRmC/RtPsILY7vdvisjdM8ejLAvtrt5yBpQoXxDs3G7QdpaUz0BfHRMtJ6P9BMsECtSL9vXMB/k265MqsOnGHPbMFq5MnQORBLzHQsfM+4oFbmERfyUe21fo+b9N0su3fBYw1VlC/Xq1DbKrXP3wvdh7a0NBZziYK9JSrX+eb2YjuMG+93T5HOL9TzvBVKtBV4ylJuiHC5iPj+w94nT0Mn6imGslM6O3XiBHc= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(9101521072)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046); SRVR:SN2PR0701MB1037; BCL:0; PCL:0; RULEID:; SRVR:SN2PR0701MB1037; X-Microsoft-Exchange-Diagnostics: 1; SN2PR0701MB1037; 4:peZlKkzY5rTe5Wpv0mQtjwf0BzFvzOAWDQ5tIWNQerKG9Ca/jhkNv934wL57O85NyjZJZSNNn1XnzlKYVMXgNcgq4azK5xlZbh19CXYMoMkC5FdnsLfxUyMseP5U9hUmcKY3cDj9Gh09xj4k7LizA8JcpDAy5YGGKB55jUB7c/4DWDieK0VaB66vMdKuzegadMGSJqrFr9FAa7EgNEKg3uj8HDZRwCbhzKO8rKNpwqkeUipE88d3voocgbk5PVhutIUEP73nyyeO/4iPr45MyvSBOlYNri5GKi5hXf30EX5bjqhAieO8TswQ7nacEpTWILZsuKWKFSmLD5IftNvgJfE01lCBvPwcFr3hv0RNVRoh3N8R30I1i6251tS3/qT2UwVaiZK5kyu+NlUJXr/h6A== X-Forefront-PRVS: 0926B0E013 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(4630300001)(6049001)(6009001)(377454003)(24454002)(13464003)(64126003)(6116002)(3846002)(47776003)(36756003)(586003)(230700001)(50466002)(5008740100001)(86362001)(2501003)(5004730100002)(42186005)(66066001)(65806001)(65956001)(81166005)(93886004)(54356999)(92566002)(2906002)(4326007)(2950100001)(77096005)(23746002)(65816999)(50986999)(87266999)(76176999)(59896002)(189998001)(80316001)(33656002)(19580405001)(19580395003)(5001770100001)(4001350100001)(1096002)(7099028); DIR:OUT; SFP:1101; SCL:1; SRVR:SN2PR0701MB1037; H:[10.0.2.115]; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; SN2PR0701MB1037; 23:foWV34YPChJOTjxtItrXZmzZXz+jkxaIvGw?= =?Windows-1252?Q?IiFlsKkL98GrqVfoQ587cjaQCzgvm1Tf5dHVMCXomk5v0ixwDKHlroM8?= =?Windows-1252?Q?dopEmLsKgL+eo36z5cqwuOa5UAzc0TcI8RiDOV34zDK6Qvy1zTM1xJ1K?= =?Windows-1252?Q?ALENvQuu5IyKw0JHXwAix8Wq29M5ChCkRHujJD/S1DGrU/GnQ91wOhNJ?= =?Windows-1252?Q?tS1ohShDfsjXxievSyt2scAKcQu9xqpdHyctwaODoJUCx8R/RIzVXnhm?= =?Windows-1252?Q?7zG8eBBCWpWu0Xp1g3BvF//mSr5WbE5X+/yxNdQPPn/ufHonzFzkiicN?= =?Windows-1252?Q?wAO2Oy/GvOISnm4A1/ZaGwqQrl/wA920ZET8EDaF767Y0nbJLv2JnwCV?= =?Windows-1252?Q?O9aUvSwhDHS+nB+mM3uw2c2pHPd7qktIIC5LfXAvfxBxjrgj+GDmytK6?= =?Windows-1252?Q?+7bM8OOPjIsZ75kSNRJuaj0hs9H2ylh5TIMRx9FlUHRsyft9cjQ5uGBO?= =?Windows-1252?Q?JsXic3eShjY4/9aQbpqIN1qv3Z2xWZgZeF+EIEmH97+lh6c1MWM5OxUe?= =?Windows-1252?Q?tbES5jzU0+g6+0bdHPYpskzaA/8NpfKnoAE+fjFQm25IRdkbCZYO6IOH?= =?Windows-1252?Q?WrNiCKN7ms7nuQTgcTf0285pRNBIdozeq+NlGjbjuBAYBdLh+K6wUoGp?= =?Windows-1252?Q?jlD8za1Ey8pGZi+bNy6w8rQbBvAJrxPPD9cIhCTzfhM2i+qfHFAVQvlD?= =?Windows-1252?Q?E91odzxTsPDHr0F4jEXneTJBDRre91BNl9S/MT526VmXyVYCosgcX9kv?= =?Windows-1252?Q?Zn/7ZY3eOlIzBZB62TLxY/ZxNIDFtptLaloP153b0had3Syw35Re27EL?= =?Windows-1252?Q?Akw0O+CJQ8tfI8a8V3n8yGjP74L1E1975sj3euHSRyhv3S05amlzGl6W?= =?Windows-1252?Q?MQcPVNvvw1IOZYLscrlfEkxQG+HXkxnXgCm8EO3xELddFMxD2EgpwGa+?= =?Windows-1252?Q?T8NNOB9d6mbroJ0N/BB13d6g80UxJVZ9AfzKJz09ezsoH7MAs+qENs1B?= =?Windows-1252?Q?YAbu3LX2ofGq3PSl0K5sdT483K8BsOL1ciBC3Yu4comoepYYWKwGoAms?= =?Windows-1252?Q?FwBzT8rWZGMn44E40Iun4ldmlJpWB0S3UkfAA/Ou5f+EDJNmhb9quYUn?= =?Windows-1252?Q?JqXhhlVuxGWyglIRkLSaw8plWy2qkQ3LGhceQJPA3HpLUiZy0iGj7SrZ?= =?Windows-1252?Q?cf5j3iT1KaFuYd3Fj5dDUDYLAsUGKNLaj4E9Ayv4=3D?= X-Microsoft-Exchange-Diagnostics: 1; SN2PR0701MB1037; 5:LAFGuy1XwTqCeJdd0VuB/tywfAbKqVyicXtNSV/Tqc6G5JZUTmhNrlQUiv5MKsQDSZxQX2gexudoV27S7SCtBKlS7KVJ/MEyGEIGnE5+CzVbYlq0fmQ5fgB9lfU1kZazFg4bVKTJLqEBI00ZLt1CNZcOMXDbjz9DnFV73W9eYukoroR5l7BjTIkqFWyMfam3; 24:DyhHZyHYYPAAMKck7N8HVusfM5izUnmJBoshyd/J3TVlOAZhzhlLFwV/7TSuUw/qr69LzNR25R7J+krbs6ds9SoQ+lwbZ8c3ddW8v4KW4KQ=; 7:4t2jchZrzJLX4hkCZFnH3TPDhRN47rHdQK/RVfiUTSyRnh1GlV/kvfOv4ElNf7dzN5uvVjusS5bBeYwVJKHHF2UeojowHJSihxURNfN+yiMQHIZgS5fxSaJY4VkbWf3mhg/FEAId7E1jRil75AKFh9mJ9k5mYDQCg9HidBGD7MhEwIEhdsYcTb1gGKlpS2eyYgFx67HPmdbIm5q+IA7mKrAGxPoLG3/oFYWxy583VIY= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2016 13:19:20.7074 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR0701MB1037 Subject: Re: [dpdk-dev] [PATCH v2 0/3] testpmd: extend commands for better scatter-gather tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Apr 2016 13:19:23 -0000 On Thu, 28 Apr 2016 13:13:20 +0000 De Lara Guarch, Pablo wrote: > > >> -----Original Message----- >> From: Maciej Czekaj [mailto:maciej.czekaj@caviumnetworks.com] >> Sent: Thursday, April 28, 2016 1:10 PM >> To: De Lara Guarch, Pablo; dev@dpdk.org >> Cc: Mcnamara, John >> Subject: Re: [dpdk-dev] [PATCH v2 0/3] testpmd: extend commands for >> better scatter-gather tests >> >> On Thu, 28 Apr 2016 08:52:59 +0000 De Lara Guarch, Pablo wrote: >>> >>> >>>> -----Original Message----- >>>> From: maciej.czekaj@caviumnetworks.com >>>> [mailto:maciej.czekaj@caviumnetworks.com] >>>> Sent: Friday, April 22, 2016 3:51 PM >>>> To: dev@dpdk.org >>>> Cc: De Lara Guarch, Pablo; Mcnamara, John; Maciej Czekaj >>>> Subject: [PATCH v2 0/3] testpmd: extend commands for better scatter- >> gather >>>> tests >>>> >>>> From: Maciej Czekaj >>>> >>>> v2: >>>> - included documentation changes >>>> - added value check for "port config all txqflags" as in --tqxflags >> paramater >>>> >>>> Maciej Czekaj (3): >>>> app/testpmd: add "enable-scatter" parameter >>>> app/testpmd: extend port config with scatter parameter >>>> app/testpmd: support setting up txq_flags value in command line >>>> >>>> app/test-pmd/cmdline.c | 86 >> +++++++++++++++++++++++++++-- >>>> app/test-pmd/parameters.c | 3 + >>>> doc/guides/testpmd_app_ug/run_app.rst | 4 ++ >>>> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 20 +++++++ >>>> 4 files changed, 109 insertions(+), 4 deletions(-) >>>> >>>> -- >>>> 1.9.1 >>> >>> Series-acked-by: Pablo de Lara >>> >>> Just one comment, maybe we should include some extra info in "show port >> info all", like txqflags or scatter mode. >>> >> >> txqflags is displayed in: >> - a forwarding info upon start command >> - show txq info >> >> scatter mode is displayed in: >> - show rxq info >> >> Still I think it is a good point to aggregate it in port info. >> >> I will address it in v3. > > Oh, true, good point. Then, probably not necessary, as we would be duplicating information. > If you think it is not necessary to add another place for that info than I think we're fine with v2.