DPDK patches and discussions
 help / color / mirror / Atom feed
From: Olivier MATZ <olivier.matz@6wind.com>
To: "Wiles, Keith" <keith.wiles@intel.com>,
	"Azarewicz, PiotrX T" <piotrx.t.azarewicz@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 1/1] cmdline: add any multi string mode to token string
Date: Thu, 28 Apr 2016 16:52:48 +0200	[thread overview]
Message-ID: <572223C0.5030104@6wind.com> (raw)
In-Reply-To: <30864A3D-C66D-41AB-A02D-32D0BF9BE95E@intel.com>

Hi Keith,

On 04/15/2016 04:41 PM, Wiles, Keith wrote:
>> While parsing token string there may be several modes:
>> - fixed single string
>> - multi-choice single string
>> - any single string
>>
>> This patch add one more mode - any multi string.
>>
>> Signed-off-by: Piotr Azarewicz <piotrx.t.azarewicz@intel.com>
>
> Does this patch also require updates to the documentation?

I did a quick check and it seems we do not dive as far in the
command line documentation (guides/sample_app_ug/cmd_line.rst).

But I agree that a comment could be added above the definition
of TOKEN_STRING_MULTI that would explain what is the behavior
in that case.

Piotr, do you think this is something you can do?

Thanks,
Olivier

  reply	other threads:[~2016-04-28 14:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-01 11:36 [dpdk-dev] [PATCH v1 " Piotr Azarewicz
2016-04-04  8:00 ` Olivier Matz
2016-04-04 14:11   ` Azarewicz, PiotrX T
2016-04-04 15:57     ` Olivier Matz
2016-04-05  6:58       ` Azarewicz, PiotrX T
2016-04-05  8:47 ` [dpdk-dev] [PATCH v2 " Piotr Azarewicz
2016-04-05 11:21   ` Olivier Matz
2016-04-05 15:39     ` Thomas Monjalon
2016-04-15 14:41   ` Wiles, Keith
2016-04-28 14:52     ` Olivier MATZ [this message]
2016-04-29  7:14       ` Azarewicz, PiotrX T
2016-04-29 14:29   ` [dpdk-dev] [PATCH v3 " Piotr Azarewicz
2016-05-02 13:32     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=572223C0.5030104@6wind.com \
    --to=olivier.matz@6wind.com \
    --cc=dev@dpdk.org \
    --cc=keith.wiles@intel.com \
    --cc=piotrx.t.azarewicz@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).