Re: [dpdk-dev] [PATCH v2] net/ifc: do not notify before HW ready

[Kevin Traynor <ktraynor@redhat.com>]

On 09/14/2018 02:25 AM, Xiao Wang wrote:
> If the device is not clearly reset by the previous driver and holds
> some invalid ring addr, and the relay thread kicks it before HW is
> properly re-configured, a bad DMA request may happen.
> 
> Besides, the notify_addr which is used by the relay thread is set in
> the vdpa_ifcvf_start function, if a kick relay happens before
> vdpa_ifcvf_start finishes, a null addr is accessed.
> 
> Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver")
> 

Looks like this should be in stable branch too. Can you confirm?	

> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
> ---
> v2:
> * Add description for the fix in the commit log.
> ---
>  drivers/net/ifc/ifcvf_vdpa.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ifc/ifcvf_vdpa.c b/drivers/net/ifc/ifcvf_vdpa.c
> index 3c5430dc0..7d3085d8d 100644
> --- a/drivers/net/ifc/ifcvf_vdpa.c
> +++ b/drivers/net/ifc/ifcvf_vdpa.c
> @@ -503,11 +503,11 @@ update_datapath(struct ifcvf_internal *internal)
>  		if (ret)
>  			goto err;
>  
> -		ret = setup_notify_relay(internal);
> +		ret = vdpa_ifcvf_start(internal);
>  		if (ret)
>  			goto err;
>  
> -		ret = vdpa_ifcvf_start(internal);
> +		ret = setup_notify_relay(internal);
>  		if (ret)
>  			goto err;
>  
> @@ -515,12 +515,12 @@ update_datapath(struct ifcvf_internal *internal)
>  	} else if (rte_atomic32_read(&internal->running) &&
>  		   (!rte_atomic32_read(&internal->started) ||
>  		    !rte_atomic32_read(&internal->dev_attached))) {
> -		vdpa_ifcvf_stop(internal);
> -
>  		ret = unset_notify_relay(internal);
>  		if (ret)
>  			goto err;
>  
> +		vdpa_ifcvf_stop(internal);
> +
>  		ret = vdpa_disable_vfio_intr(internal);
>  		if (ret)
>  			goto err;
>