From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
Cc: thomas.monjalon@6wind.com
Subject: Re: [dpdk-dev] [PATCH] eal: add missing include to debug header
Date: Thu, 5 May 2016 17:07:58 +0100 [thread overview]
Message-ID: <572B6FDE.4000209@intel.com> (raw)
In-Reply-To: <20160505125942.GA14228@bricha3-MOBL3>
On 5/5/2016 1:59 PM, Bruce Richardson wrote:
> On Wed, May 04, 2016 at 05:37:56PM +0100, Bruce Richardson wrote:
>> The header file rte_debug.h makes use of the "unlikely" macro which
>> means it should include the rte_branch_prediction.h header file.
>>
>> Fixes: 50705e8e3cdd ("eal: add assert macro for debug")
>>
>> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>> ---
>> lib/librte_eal/common/include/rte_debug.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/lib/librte_eal/common/include/rte_debug.h b/lib/librte_eal/common/include/rte_debug.h
>> index 9260eda..cab6fb4 100644
>> --- a/lib/librte_eal/common/include/rte_debug.h
>> +++ b/lib/librte_eal/common/include/rte_debug.h
>> @@ -44,6 +44,7 @@
>> */
>>
>> #include "rte_log.h"
>> +#include "rte_branch_prediction.h"
>>
>> #ifdef __cplusplus
>> extern "C" {
>
> Ping on this patch - any comments or concerns?
> It's a fairly trivial fix that prevents issues with testing some other patches
> on the mainline.
>
Tested on top of David Marchand's 12123-12139 patchset.
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
next prev parent reply other threads:[~2016-05-05 16:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-04 16:37 Bruce Richardson
2016-05-05 12:59 ` Bruce Richardson
2016-05-05 16:07 ` Ferruh Yigit [this message]
2016-05-05 20:49 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572B6FDE.4000209@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).