From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id D87781B48A for ; Tue, 26 Mar 2019 21:53:02 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 7F21F46AF; Tue, 26 Mar 2019 16:53:01 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 26 Mar 2019 16:53:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=XIdn0Ux5Ozglhf7yeflgjfmvQOaVqqaeds3wYKEF3RE=; b=U5fI+Aewaemq km9ZGMGSUtzeadcFaqHI0VZjbISYuMju7l96vEluyqUpGBYp048TW5Lp1XYS0HlE 5/mc1q/NQaTC/zWa/W6mJrJhnIF1yJMQO+oW1a9st1v8k73vAyKv6MnqL3fz7QQ4 lQc35lj0DWgn8lSKcoaCExDtLwbYZfg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=XIdn0Ux5Ozglhf7yeflgjfmvQOaVqqaeds3wYKEF3 RE=; b=QgYZPywS2fhyRykhva2yo7H3SWNuINXL8wEUzWE9Huz0tlpXwMUbEAJyw 7XPBFCdrZszhwol/mCJg4yJmRNy2IYM2WRvJdidGE0PQ0NWNOSw2wVRB+Gj6TZev k0Ox1jZjRe73ZQRAVnd3W5DYarG/pOLKY38jNCxAWFLhSYLB1OhaqkKCkp8ldxEk 6PaqUc+XcM2qU+50aO2YsIJcP/MWhfGV2p3E9sbqIvk99iQEHRflDJq6g/+//E35 UJ/hQkbyTXAzFW3HTcoU5PUnYCgECaGxqYU2aDOu01h0Mevp88bGAx5D/P3Mu+uY cUc49qPAHBfWy3T089Ntgq1x/ut8A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkedtgdduudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 54CBEE4805; Tue, 26 Mar 2019 16:52:59 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger Cc: Anand Rawat , dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, bruce.richardson@intel.com Date: Tue, 26 Mar 2019 21:52:57 +0100 Message-ID: <5731264.uOF5Ix2MiQ@xps> In-Reply-To: <20190326120621.73d46f74@shemminger-XPS-13-9360> References: <20190306041634.12976-1-anand.rawat@intel.com> <20190326060238.9884-5-anand.rawat@intel.com> <20190326120621.73d46f74@shemminger-XPS-13-9360> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Mar 2019 20:53:03 -0000 26/03/2019 20:06, Stephen Hemminger: > On Mon, 25 Mar 2019 23:02:34 -0700 > Anand Rawat wrote: > > > +/*- > > + * SPDX-License-Identifier: BSD-3-Clause > > + * > > + * Copyright (c) 1991, 1993 > > + * The Regents of the University of California. All rights reserved. > > + * > > + * Redistribution and use in source and binary forms, with or without > > + * modification, are permitted provided that the following conditions > > + * are met: > > + * 1. Redistributions of source code must retain the above copyright > > + * notice, this list of conditions and the following disclaimer. > > + * 2. Redistributions in binary form must reproduce the above copyright > > + * notice, this list of conditions and the following disclaimer in the > > + * documentation and/or other materials provided with the distribution. > > + * 3. Neither the name of the University nor the names of its contributors > > + * may be used to endorse or promote products derived from this software > > + * without specific prior written permission. > > + * > > + * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND > > + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE > > + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE > > + * ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE > > + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL > > + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS > > + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) > > + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT > > + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY > > + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF > > + * SUCH DAMAGE. > > + * > > If you have SPDX license identifier then the text boilerplate is unnecessary > and not desired. Even better would be to get it as a dependency outside of DPDK. Where this code come from? How other projects on Windows get it? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 1A530A05D3 for ; Tue, 26 Mar 2019 21:53:06 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E7AF01B48C; Tue, 26 Mar 2019 21:53:04 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id D87781B48A for ; Tue, 26 Mar 2019 21:53:02 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 7F21F46AF; Tue, 26 Mar 2019 16:53:01 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 26 Mar 2019 16:53:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=XIdn0Ux5Ozglhf7yeflgjfmvQOaVqqaeds3wYKEF3RE=; b=U5fI+Aewaemq km9ZGMGSUtzeadcFaqHI0VZjbISYuMju7l96vEluyqUpGBYp048TW5Lp1XYS0HlE 5/mc1q/NQaTC/zWa/W6mJrJhnIF1yJMQO+oW1a9st1v8k73vAyKv6MnqL3fz7QQ4 lQc35lj0DWgn8lSKcoaCExDtLwbYZfg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=XIdn0Ux5Ozglhf7yeflgjfmvQOaVqqaeds3wYKEF3 RE=; b=QgYZPywS2fhyRykhva2yo7H3SWNuINXL8wEUzWE9Huz0tlpXwMUbEAJyw 7XPBFCdrZszhwol/mCJg4yJmRNy2IYM2WRvJdidGE0PQ0NWNOSw2wVRB+Gj6TZev k0Ox1jZjRe73ZQRAVnd3W5DYarG/pOLKY38jNCxAWFLhSYLB1OhaqkKCkp8ldxEk 6PaqUc+XcM2qU+50aO2YsIJcP/MWhfGV2p3E9sbqIvk99iQEHRflDJq6g/+//E35 UJ/hQkbyTXAzFW3HTcoU5PUnYCgECaGxqYU2aDOu01h0Mevp88bGAx5D/P3Mu+uY cUc49qPAHBfWy3T089Ntgq1x/ut8A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrkedtgdduudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 54CBEE4805; Tue, 26 Mar 2019 16:52:59 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger Cc: Anand Rawat , dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, bruce.richardson@intel.com Date: Tue, 26 Mar 2019 21:52:57 +0100 Message-ID: <5731264.uOF5Ix2MiQ@xps> In-Reply-To: <20190326120621.73d46f74@shemminger-XPS-13-9360> References: <20190306041634.12976-1-anand.rawat@intel.com> <20190326060238.9884-5-anand.rawat@intel.com> <20190326120621.73d46f74@shemminger-XPS-13-9360> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v5 4/8] eal: sys/queue.h implementation for windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190326205257.iC2yL00kvrfcLrK8JjN-jm19RLwf-S034SQS_87MAXs@z> 26/03/2019 20:06, Stephen Hemminger: > On Mon, 25 Mar 2019 23:02:34 -0700 > Anand Rawat wrote: > > > +/*- > > + * SPDX-License-Identifier: BSD-3-Clause > > + * > > + * Copyright (c) 1991, 1993 > > + * The Regents of the University of California. All rights reserved. > > + * > > + * Redistribution and use in source and binary forms, with or without > > + * modification, are permitted provided that the following conditions > > + * are met: > > + * 1. Redistributions of source code must retain the above copyright > > + * notice, this list of conditions and the following disclaimer. > > + * 2. Redistributions in binary form must reproduce the above copyright > > + * notice, this list of conditions and the following disclaimer in the > > + * documentation and/or other materials provided with the distribution. > > + * 3. Neither the name of the University nor the names of its contributors > > + * may be used to endorse or promote products derived from this software > > + * without specific prior written permission. > > + * > > + * THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND > > + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE > > + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE > > + * ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE > > + * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL > > + * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS > > + * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) > > + * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT > > + * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY > > + * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF > > + * SUCH DAMAGE. > > + * > > If you have SPDX license identifier then the text boilerplate is unnecessary > and not desired. Even better would be to get it as a dependency outside of DPDK. Where this code come from? How other projects on Windows get it?