Signed-off-by: Radu Nicolau <radu.nicolau@intel.com> --- usertools/dpdk-devbind.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py index b1d1498..40b4bee 100755 --- a/usertools/dpdk-devbind.py +++ b/usertools/dpdk-devbind.py @@ -45,6 +45,8 @@ 'SVendor': None, 'SDevice': None} intel_ioat_skx = {'Class': '08', 'Vendor': '8086', 'Device': '2021', 'SVendor': None, 'SDevice': None} +intel_ioat_icx = {'Class': '08', 'Vendor': '8086', 'Device': '0b00', + 'SVendor': None, 'SDevice': None} intel_ntb_skx = {'Class': '06', 'Vendor': '8086', 'Device': '201c', 'SVendor': None, 'SDevice': None} @@ -54,7 +56,7 @@ eventdev_devices = [cavium_sso, cavium_tim, octeontx2_sso] mempool_devices = [cavium_fpa, octeontx2_npa] compress_devices = [cavium_zip] -misc_devices = [intel_ioat_bdw, intel_ioat_skx, intel_ntb_skx, octeontx2_dma] +misc_devices = [intel_ioat_bdw, intel_ioat_skx, intel_ioat_icx, intel_ntb_skx, octeontx2_dma] # global dict ethernet devices present. Dictionary indexed by PCI address. # Each device within this is itself a dictionary of device properties -- 2.7.4
Signed-off-by: Radu Nicolau <radu.nicolau@intel.com> --- drivers/raw/ioat/ioat_rawdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/raw/ioat/ioat_rawdev.c b/drivers/raw/ioat/ioat_rawdev.c index af8414b..a8a48f9 100644 --- a/drivers/raw/ioat/ioat_rawdev.c +++ b/drivers/raw/ioat/ioat_rawdev.c @@ -26,6 +26,7 @@ static struct rte_pci_driver ioat_pmd_drv; #define IOAT_DEVICE_ID_BDX7 0x6f27 #define IOAT_DEVICE_ID_BDXE 0x6f2E #define IOAT_DEVICE_ID_BDXF 0x6f2F +#define IOAT_DEVICE_ID_ICX 0x0b00 #define IOAT_PMD_LOG(level, fmt, args...) rte_log(RTE_LOG_ ## level, \ ioat_pmd_logtype, "%s(): " fmt "\n", __func__, ##args) @@ -371,6 +372,7 @@ static const struct rte_pci_id pci_id_ioat_map[] = { { RTE_PCI_DEVICE(IOAT_VENDOR_ID, IOAT_DEVICE_ID_BDX7) }, { RTE_PCI_DEVICE(IOAT_VENDOR_ID, IOAT_DEVICE_ID_BDXE) }, { RTE_PCI_DEVICE(IOAT_VENDOR_ID, IOAT_DEVICE_ID_BDXF) }, + { RTE_PCI_DEVICE(IOAT_VENDOR_ID, IOAT_DEVICE_ID_ICX) }, { .vendor_id = 0, /* sentinel */ }, }; -- 2.7.4
29/04/2020 11:37, Radu Nicolau:
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
The commit log is... short :-)
Please could you add few words about the HW you want to support?
Maybe a link to a description in the web?
29/04/2020 11:37, Radu Nicolau:
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
The commit log of patch 2 is not better than in patch 1.
I suggest to squash both commits together.
Add support for Ice Lake IOAT DMA engine PCI Device ID. Signed-off-by: Radu Nicolau <radu.nicolau@intel.com> --- v2: squash commits, add description. drivers/raw/ioat/ioat_rawdev.c | 2 ++ usertools/dpdk-devbind.py | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/raw/ioat/ioat_rawdev.c b/drivers/raw/ioat/ioat_rawdev.c index af8414b..a8a48f9 100644 --- a/drivers/raw/ioat/ioat_rawdev.c +++ b/drivers/raw/ioat/ioat_rawdev.c @@ -26,6 +26,7 @@ static struct rte_pci_driver ioat_pmd_drv; #define IOAT_DEVICE_ID_BDX7 0x6f27 #define IOAT_DEVICE_ID_BDXE 0x6f2E #define IOAT_DEVICE_ID_BDXF 0x6f2F +#define IOAT_DEVICE_ID_ICX 0x0b00 #define IOAT_PMD_LOG(level, fmt, args...) rte_log(RTE_LOG_ ## level, \ ioat_pmd_logtype, "%s(): " fmt "\n", __func__, ##args) @@ -371,6 +372,7 @@ static const struct rte_pci_id pci_id_ioat_map[] = { { RTE_PCI_DEVICE(IOAT_VENDOR_ID, IOAT_DEVICE_ID_BDX7) }, { RTE_PCI_DEVICE(IOAT_VENDOR_ID, IOAT_DEVICE_ID_BDXE) }, { RTE_PCI_DEVICE(IOAT_VENDOR_ID, IOAT_DEVICE_ID_BDXF) }, + { RTE_PCI_DEVICE(IOAT_VENDOR_ID, IOAT_DEVICE_ID_ICX) }, { .vendor_id = 0, /* sentinel */ }, }; diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py index b1d1498..40b4bee 100755 --- a/usertools/dpdk-devbind.py +++ b/usertools/dpdk-devbind.py @@ -45,6 +45,8 @@ 'SVendor': None, 'SDevice': None} intel_ioat_skx = {'Class': '08', 'Vendor': '8086', 'Device': '2021', 'SVendor': None, 'SDevice': None} +intel_ioat_icx = {'Class': '08', 'Vendor': '8086', 'Device': '0b00', + 'SVendor': None, 'SDevice': None} intel_ntb_skx = {'Class': '06', 'Vendor': '8086', 'Device': '201c', 'SVendor': None, 'SDevice': None} @@ -54,7 +56,7 @@ eventdev_devices = [cavium_sso, cavium_tim, octeontx2_sso] mempool_devices = [cavium_fpa, octeontx2_npa] compress_devices = [cavium_zip] -misc_devices = [intel_ioat_bdw, intel_ioat_skx, intel_ntb_skx, octeontx2_dma] +misc_devices = [intel_ioat_bdw, intel_ioat_skx, intel_ioat_icx, intel_ntb_skx, octeontx2_dma] # global dict ethernet devices present. Dictionary indexed by PCI address. # Each device within this is itself a dictionary of device properties -- 2.7.4
On Wed, Apr 29, 2020 at 01:29:30PM +0100, Radu Nicolau wrote:
> Add support for Ice Lake IOAT DMA engine PCI Device ID.
>
> Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> ---
> v2: squash commits, add description.
>
> drivers/raw/ioat/ioat_rawdev.c | 2 ++
> usertools/dpdk-devbind.py | 4 +++-
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
Reviewed-by: Bruce Richardson <bruce.richardson@intel.com>
05/05/2020 18:07, Bruce Richardson:
> On Wed, Apr 29, 2020 at 01:29:30PM +0100, Radu Nicolau wrote:
> > Add support for Ice Lake IOAT DMA engine PCI Device ID.
> >
> > Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
> > ---
> > v2: squash commits, add description.
> >
> > drivers/raw/ioat/ioat_rawdev.c | 2 ++
> > usertools/dpdk-devbind.py | 4 +++-
> > 2 files changed, 5 insertions(+), 1 deletion(-)
> >
> Reviewed-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks